Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added ability to specify request options via config #40

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

zeevl
Copy link

@zeevl zeevl commented Aug 29, 2014

this allows the consumer to supply additional options to the http.get request call by doing

   mixpanel.init('....', { request_options: { scheme: 'http' }});

The longer story is, i'm using the module from within a chrome extension. That extension sometimes makes mixpanel calls from a window whose protocol is chrome-extension://. Since no scheme is specified, http uses the document's scheme, so the request ends up being chrome-extension://api.mixpanel.com.... fail.

Updated tests, everything still pases.

zeev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant