Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix automatic events settings #511

Merged
merged 2 commits into from
Jan 31, 2022
Merged

Fix automatic events settings #511

merged 2 commits into from
Jan 31, 2022

Conversation

zihejia
Copy link
Contributor

@zihejia zihejia commented Jan 31, 2022 •
edited
Loading

trackAutomaticEvents param in initialize should take precedence over Autotrack settings from the Mixpanel, but if trackAutomaticEvents is not set, should respect Autotrack settings from the Mixpanel.

@zihejia zihejia changed the title fix automatic events settings Fix automatic events settings Jan 31, 2022
@zihejia zihejia added the bug label Jan 31, 2022
jaredmixpanel
jaredmixpanel approved these changes Jan 31, 2022
View reviewed changes
Copy link
Contributor

@jaredmixpanel jaredmixpanel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@zihejia zihejia merged commit cb6c5d6 into master Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaredmixpanel jaredmixpanel jaredmixpanel approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zihejia @jaredmixpanel