Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

send millisecond precision timestamps #146

Merged
merged 3 commits into from
Aug 4, 2022
Merged

Conversation

jaredmixpanel
Copy link
Contributor

No description provided.

Copy link
Contributor

@zihejia zihejia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jaredmixpanel jaredmixpanel merged commit 8821427 into master Aug 4, 2022
@martins-jansevskis
Copy link

The mixpanel documentation are still saying $duration is in 'seconds' for every timed event not just unity, but Android, iOS as well.
Has the $duration been changed for every SDK or now it is just a random number that is in milliseconds from Unity and seconds from other SDKs?

What happens to clients who have production applications with some users still on 3.0.1 and others in 3.3.1? Are the data changed to seconds when storing in database? Or now every timed event can be considered invalid?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants