Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PyYAML to version 6.0.0 and black to 22.3.0 #11

Merged
merged 3 commits into from
Apr 13, 2022

Conversation

keirwl
Copy link
Contributor

@keirwl keirwl commented Apr 12, 2022

Slippers using PyYAML ^5.4.1 is causing dependency conflicts with other PyYAML-using packages in a project of mine. It appears that the only backwards-incompatible change from PyYAML 5 to 6 is dropping support for Python 2, so it is compatible with slippers.

@mixxorz
Copy link
Owner

mixxorz commented Apr 13, 2022

Hiya. Thanks for the PR.

I don't want to require people to update PyYAML versions. If we could, let's set the version requirement to something like PyYAML = ">=5.4.0, <7.0.0".

Also, thanks for updating black!

@keirwl keirwl changed the title Update PyYAML to version 6.0.0 Update PyYAML to version 6.0.0 and black to 22.3.0 Apr 13, 2022
@keirwl
Copy link
Contributor Author

keirwl commented Apr 13, 2022

Hello!

Good call; I've set it to ">=5.4.0, <7.0.0" as requested

Copy link
Owner

@mixxorz mixxorz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. Thanks! I'll merge this in.

@mixxorz mixxorz merged commit 254c720 into mixxorz:main Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants