Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mapping for MIDI Controller Behringer BCR2000 #310
Mapping for MIDI Controller Behringer BCR2000 #310
Changes from 8 commits
4f5a020
bdce451
fe633d2
376cf5e
d6cf4c2
52106fc
e55e57e
e8ef7ee
0e73cd0
fc30631
7ccc005
25e77ef
c000dbd
c35ea26
e39c56e
35601ae
5c482a0
844cc0f
8c5d15a
fdce603
019f5c4
e64a98f
dacfb9f
536270b
5dd1bbd
28ab6dc
fc40300
73c1782
e0e0f51
7ce0bd9
1170d6e
34050f5
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this belongs into the user manual. You can put developer documentation into the source file itself, which also decreases the likelihood of becoming outdated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR also contains a PNG file. Since it's not used and the SVG is preferable anyway, please remove it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a table that explains how the mapping works. I suggest to explain that the left half of the two top rows is used for deck 1, and the right half for deck 2, then make a table that explains the knobs and buttons from left to right. If there's a label on the hardware, please mention it:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a table, please check if it's well-arranged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All static files should go into the
source/_static/_controllers
directory.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I moved all files but the RST, and hope the references will not be broken.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unneeded IMHO.