Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MC7000 - added notes and replaced pictures #369

Merged
merged 3 commits into from
Apr 17, 2021

Conversation

toszlanyi
Copy link
Contributor

@toszlanyi toszlanyi commented Apr 8, 2021

here again the updated manual for the MC7000 mapping tweaks on PR #3738

source/hardware/controllers/denon_mc7000.rst Outdated Show resolved Hide resolved
source/hardware/controllers/denon_mc7000.rst Outdated Show resolved Hide resolved
source/hardware/controllers/denon_mc7000.rst Outdated Show resolved Hide resolved
Comment on lines 281 to 282
| This mode lets you set a dedicated loop from current position.
| Another push on the Pad button will turn the loop off.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| This mode lets you set a dedicated loop from current position.
| Another push on the Pad button will turn the loop off.
This mode lets you set a dedicated loop from current position.
Another push on the Pad button will turn the loop off.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to keep line breaks in all those instances where I used "|"

Comment on lines 305 to 306
| Press and hold ":hwlabel:`SHIFT`" and then push a PAD button to jump even more beats.
| 16, 32, 64 and 128 forward on the upper row and backwards on the lower row.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| Press and hold ":hwlabel:`SHIFT`" and then push a PAD button to jump even more beats.
| 16, 32, 64 and 128 forward on the upper row and backwards on the lower row.
Press and hold :hwlabel:`SHIFT` and then push a pad button to jump even more beats.
16, 32, 64 and 128 forward on the upper row and backwards on the lower row.

Copy link
Contributor Author

@toszlanyi toszlanyi Apr 9, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wanna keep line breaks as on the previous comment so that all possible values are not broken between lines. "pad" is now lowercase in all text where "Pad button" or "PAD button" was mentiond. "Performance Pad" stays as is.

source/hardware/controllers/denon_mc7000.rst Outdated Show resolved Hide resolved
source/hardware/controllers/denon_mc7000.rst Outdated Show resolved Hide resolved
@Holzhaus Holzhaus merged commit 38c3a57 into mixxxdj:2.3 Apr 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants