AutoDJ: fix GUI freeze when updating duration of many selected tracks

* move the duration collection to TrackDAO * query the database duration column instead of inspecting each Track object
mixxxdj · Jan 7, 2024 · 2eb9e24 · 2eb9e24
1 parent af5ca37
commit 2eb9e24
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/src/library/autodj/dlgautodj.cpp b/src/library/autodj/dlgautodj.cpp
@@ -27,6 +27,7 @@ DlgAutoDJ::DlgAutoDJ(WLibrary* parent,
         : QWidget(parent),
           Ui::DlgAutoDJ(),
           m_pConfig(pConfig),
+          m_pLibrary(pLibrary),
           m_pAutoDJProcessor(pProcessor),
           m_pTrackTableView(new WTrackTableView(this,
                   m_pConfig,
@@ -367,12 +368,14 @@ void DlgAutoDJ::updateSelectionInfo() {
 
     QModelIndexList indices = m_pTrackTableView->selectionModel()->selectedRows();
 
+    QList<TrackId> ids;
     for (int i = 0; i < indices.size(); ++i) {
-        TrackPointer pTrack = m_pAutoDJTableModel->getTrack(indices.at(i));
-        if (pTrack) {
-            duration += pTrack->getDuration();
-        }
+        ids.append(m_pAutoDJTableModel->getTrackId(indices.at(i)));
     }
+    TrackDAO* pTrackDAO = &(m_pLibrary->trackCollectionManager()
+                                    ->internalCollection()
+                                    ->getTrackDAO());
+    duration = pTrackDAO->getTrackDurationsTotal(ids);
 
     QString label;
 

diff --git a/src/library/autodj/dlgautodj.h b/src/library/autodj/dlgautodj.h
@@ -61,6 +61,7 @@ class DlgAutoDJ : public QWidget, public Ui::DlgAutoDJ, public LibraryView {
     void keyPressEvent(QKeyEvent* pEvent) override;
 
     const UserSettingsPointer m_pConfig;
+    Library* const m_pLibrary;
 
     AutoDJProcessor* const m_pAutoDJProcessor;
     WTrackTableView* const m_pTrackTableView;