Move default implementation of createPlaylistModelForPlaylist() to cp…

…p file
mixxxdj · Jun 14, 2023 · 324bf99 · 324bf99
1 parent 6385f30
commit 324bf99
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 5 deletions.
diff --git a/src/library/baseexternallibraryfeature.cpp b/src/library/baseexternallibraryfeature.cpp
@@ -172,3 +172,10 @@ void BaseExternalLibraryFeature::appendTrackIdsFromRightClickIndex(
         trackIds->append(trackId);
     }
 }
+
+std::unique_ptr<BaseSqlTableModel>
+BaseExternalLibraryFeature::createPlaylistModelForPlaylist(
+        const QString& playlist) {
+    Q_UNUSED(playlist);
+    return {};
+}
diff --git a/src/library/baseexternallibraryfeature.h b/src/library/baseexternallibraryfeature.h
@@ -26,12 +26,9 @@ class BaseExternalLibraryFeature : public LibraryFeature {
     void onRightClickChild(const QPoint& globalPos, const QModelIndex& index) override;
 
   protected:
-    // Must be implemented by external Libraries copied to Mixxx DB
+    // Must be re-implemented by external Libraries copied to Mixxx DB
     virtual std::unique_ptr<BaseSqlTableModel> createPlaylistModelForPlaylist(
-            const QString& playlist) {
-        Q_UNUSED(playlist);
-        return {};
-    }
+            const QString& playlist);
     // Must be implemented by external Libraries not copied to Mixxx DB
     virtual void appendTrackIdsFromRightClickIndex(QList<TrackId>* trackIds, QString* pPlaylist);