Silence warnings for expected invalid keys.

This fixes lp1942350 a regression from #4229
mixxxdj · Sep 1, 2021 · 70ebab0 · 70ebab0
1 parent 6f4fc8e
commit 70ebab0
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/src/control/control.cpp b/src/control/control.cpp
@@ -134,9 +134,11 @@ QSharedPointer<ControlDoublePrivate> ControlDoublePrivate::getControl(
         bool bPersist,
         double defaultValue) {
     if (!key.isValid()) {
-        qWarning() << "ControlDoublePrivate::getControl returning nullptr"
-                   << "for invalid ConfigKey" << key;
-        DEBUG_ASSERT(flags.testFlag(ControlFlag::AllowInvalidKey));
+        if (!flags.testFlag(ControlFlag::AllowInvalidKey)) {
+            qWarning() << "ControlDoublePrivate::getControl returning nullptr"
+                       << "for invalid ConfigKey" << key;
+            DEBUG_ASSERT(!"Unexpected invalid key");
+        }
         return nullptr;
     }