Skip to content

Commit

Permalink
mark const functions as const
Browse files Browse the repository at this point in the history
Co-authored-by: Swiftb0y <12380386+Swiftb0y@users.noreply.github.com>
  • Loading branch information
daschuer and Swiftb0y authored Aug 10, 2023
1 parent d06bd44 commit 96cfa23
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions src/library/itunes/itunesfeature.h
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,8 @@ class ITunesFeature : public BaseExternalLibraryFeature {

TreeItemModel* sidebarModel() const override;

// This is called from the ITunesXMLImporter thread
bool isImportCanceled() {
// This is called from the ITunesXMLImporter thread and generally threadsafe
bool isImportCanceled() const {
return m_cancelImport.load();
}

Expand Down
2 changes: 1 addition & 1 deletion src/library/itunes/itunesimporter.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ ITunesImporter::ITunesImporter(ITunesFeature* pParentFeature)
: m_pParentFeature(pParentFeature) {
}

bool ITunesImporter::canceled() {
bool ITunesImporter::cancelled() const {

Check failure on line 8 in src/library/itunes/itunesimporter.cpp

View workflow job for this annotation

GitHub Actions / clazy

out-of-line definition of 'cancelled' does not match any declaration in 'ITunesImporter'

Check failure on line 8 in src/library/itunes/itunesimporter.cpp

View workflow job for this annotation

GitHub Actions / Ubuntu 22.04 (gcc)

no declaration matches ‘bool ITunesImporter::cancelled() const’

Check failure on line 8 in src/library/itunes/itunesimporter.cpp

View workflow job for this annotation

GitHub Actions / Ubuntu 22.04 (Qt 6.2, gcc)

no declaration matches ‘bool ITunesImporter::cancelled() const’

Check failure on line 8 in src/library/itunes/itunesimporter.cpp

View workflow job for this annotation

GitHub Actions / coverage

no declaration matches ‘bool ITunesImporter::cancelled() const’

Check failure on line 8 in src/library/itunes/itunesimporter.cpp

View workflow job for this annotation

GitHub Actions / Windows 2019 (MSVC)

'cancelled': is not a member of 'ITunesImporter'

Check failure on line 8 in src/library/itunes/itunesimporter.cpp

View workflow job for this annotation

GitHub Actions / Windows 2019 (MSVC)

'cancelled': modifiers not allowed on nonmember functions
// The parent feature may be null during testing
if (m_pParentFeature) {

Check failure on line 10 in src/library/itunes/itunesimporter.cpp

View workflow job for this annotation

GitHub Actions / Windows 2019 (MSVC)

'm_pParentFeature': undeclared identifier
return m_pParentFeature->isImportCanceled();

Check failure on line 11 in src/library/itunes/itunesimporter.cpp

View workflow job for this annotation

GitHub Actions / Windows 2019 (MSVC)

'm_pParentFeature': undeclared identifier
Expand Down

0 comments on commit 96cfa23

Please sign in to comment.