Apply suggestions from code review

Co-authored-by: Daniel Schürmann <daschuer@mixxx.org>
mixxxdj · Jun 9, 2024 · da3e4a4 · da3e4a4
1 parent 905bce1
commit da3e4a4
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/audio/frame.h b/src/audio/frame.h
@@ -45,7 +45,7 @@ class FramePos final {
     }
 
     static constexpr FramePos fromSamplePos(double samplePos,
-            mixxx::audio::SignalInfo signalInfo) {
+            const mixxx::audio::SignalInfo& signalInfo) {
         return FramePos(static_cast<double>(samplePos) / signalInfo.getChannelCount());
     }
 

diff --git a/src/engine/enginebuffer.cpp b/src/engine/enginebuffer.cpp
@@ -900,8 +900,8 @@ void EngineBuffer::processTrackLocked(
     // (1.0 being normal rate. 2.0 plays at 2x speed -- 2 track seconds
     // pass for every 1 real second). Depending on whether
     // keylock is enabled, this is applied to either the rate or the tempo.
-    int outputBufferSize = iBufferSize,
-        stereoPairCount = m_channelCount / mixxx::audio::ChannelCount::stereo();
+    int outputBufferSize = iBufferSize;
+    int stereoPairCount = m_channelCount / mixxx::audio::ChannelCount::stereo();
     // The speed is calculated out of the buffer size for the stereo channel
     // output, after mixing multi channel (stem) together
     if (stereoPairCount > 1) {