TrackDAO: Avoid bitwise or to calculate boolean expression

mixxxdj · Jan 18, 2022 · e6eb30c · e6eb30c
1 parent db31296
commit e6eb30c
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/src/library/dao/trackdao.cpp b/src/library/dao/trackdao.cpp
@@ -1506,9 +1506,9 @@ TrackPointer TrackDAO::getTrackById(TrackId trackId) const {
         }
         for (int i = 0; i < recordCount; ++i) {
             TrackPopulatorFn populator = columns[i].populator;
-            if (populator) {
+            if (populator && (*populator)(queryRecord, i, pTrack.get())) {
                 // If any populator says the track should be dirty then we dirty it.
-                shouldDirty |= (*populator)(queryRecord, i, pTrack.get());
+                shouldDirty = true;
             }
         }
     }