Skip to content

Commit

Permalink
Use override keyword to make clazy happy
Browse files Browse the repository at this point in the history
  • Loading branch information
daschuer committed Jun 15, 2023
1 parent 2029d36 commit f6999bd
Show file tree
Hide file tree
Showing 3 changed files with 23 additions and 23 deletions.
14 changes: 7 additions & 7 deletions src/library/banshee/bansheefeature.h
Original file line number Diff line number Diff line change
Expand Up @@ -19,21 +19,21 @@ class BansheeFeature : public BaseExternalLibraryFeature {
Q_OBJECT
public:
BansheeFeature(Library* pLibrary, UserSettingsPointer pConfig);
virtual ~BansheeFeature();
~BansheeFeature() override;
static bool isSupported();
static void prepareDbPath(UserSettingsPointer pConfig);

virtual QVariant title();
virtual QIcon getIcon();
QVariant title() override;
QIcon getIcon() override;

virtual TreeItemModel* getChildModel();
TreeItemModel* getChildModel() override;

public slots:
virtual void activate();
virtual void activateChild(const QModelIndex& index);
void activate() override;
void activateChild(const QModelIndex& index) override;

private:
virtual void appendTrackIdsFromRightClickIndex(QList<TrackId>* trackIds, QString* pPlaylist);
void appendTrackIdsFromRightClickIndex(QList<TrackId>* trackIds, QString* pPlaylist) override;

BansheePlaylistModel* m_pBansheePlaylistModel;
TreeItemModel m_childModel;
Expand Down
20 changes: 10 additions & 10 deletions src/library/browse/browsefeature.h
Original file line number Diff line number Diff line change
Expand Up @@ -28,27 +28,27 @@ class BrowseFeature : public LibraryFeature {
BrowseFeature(Library* pLibrary,
UserSettingsPointer pConfig,
RecordingManager* pRecordingManager);
virtual ~BrowseFeature();
~BrowseFeature() override;

QVariant title();
QIcon getIcon();
QVariant title() override;
QIcon getIcon() override;

void bindLibraryWidget(WLibrary* libraryWidget,
KeyboardEventFilter* keyboard);
void bindSidebarWidget(WLibrarySidebar* pSidebarWidget);
KeyboardEventFilter* keyboard) override;
void bindSidebarWidget(WLibrarySidebar* pSidebarWidget) override;

TreeItemModel* getChildModel();
TreeItemModel* getChildModel() override;

void releaseBrowseThread();

public slots:
void slotAddQuickLink();
void slotRemoveQuickLink();
void slotAddToLibrary();
void activate();
void activateChild(const QModelIndex& index);
void onRightClickChild(const QPoint& globalPos, const QModelIndex& index);
void onLazyChildExpandation(const QModelIndex& index);
void activate() override;
void activateChild(const QModelIndex& index) override;
void onRightClickChild(const QPoint& globalPos, const QModelIndex& index) override;
void onLazyChildExpandation(const QModelIndex& index) override;
void slotLibraryScanStarted();
void slotLibraryScanFinished();

Expand Down
12 changes: 6 additions & 6 deletions src/library/rhythmbox/rhythmboxfeature.h
Original file line number Diff line number Diff line change
Expand Up @@ -18,21 +18,21 @@ class RhythmboxFeature : public BaseExternalLibraryFeature {
Q_OBJECT
public:
RhythmboxFeature(Library* pLibrary, UserSettingsPointer pConfig);
virtual ~RhythmboxFeature();
~RhythmboxFeature() override;
static bool isSupported();

QVariant title();
QIcon getIcon();
QVariant title() override;
QIcon getIcon() override;

TreeItemModel* getChildModel();
TreeItemModel* getChildModel() override;
// processes the music collection
TreeItem* importMusicCollection();
// processes the playlist entries
TreeItem* importPlaylists();

public slots:
void activate();
void activateChild(const QModelIndex& index);
void activate() override;
void activateChild(const QModelIndex& index) override;
void onTrackCollectionLoaded();

protected:
Expand Down

0 comments on commit f6999bd

Please sign in to comment.