Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Numark DJ2GO2 Touch tempo slider issues #10586

Open
mixxxbot opened this issue Aug 23, 2022 · 12 comments
Open

Numark DJ2GO2 Touch tempo slider issues #10586

mixxxbot opened this issue Aug 23, 2022 · 12 comments
Labels

Comments

@mixxxbot
Copy link
Collaborator

Reported by: sals3r0
Date: 2021-10-24T19:53:55Z
Status: Fix Committed
Importance: Medium
Launchpad Issue: lp1948596


Hello,

testing the new Numark DJ2GO2 Touch controller with Mixxx 2.3.1, so far so good but there are two issues with tempo sliders:

  1. the mapping is reversed - moving the slider to (+) side at the controler moves the tempo to (-) side at the UI
  2. it is not possible to move the slider to zero point (0%), it always ends up in 0.06% or something like that in my case (the mapping should contain some "zero threshold")

Kind regards,
Karel

  • OS: Linux KDE Neon 20.04 64bit
  • Arch: x64 (Intel Core i7)
  • Numark DJ2GO2 Touch
@mixxxbot mixxxbot added the bug label Aug 23, 2022
@mixxxbot
Copy link
Collaborator Author

Commented by: tezzy
Date: 2021-12-31T16:41:03Z


Hi,

Looking at item 1:

Have you looked at Preferences > Decks > Speed > Slider range > Down Increases Speed?

It seems checked by default on some presets eg Technics SL-1210 8%

Looking at item 2:

Have you tried relearning the sliders in the MIDI mapping wizard?

I hope that helps.

@mixxxbot
Copy link
Collaborator Author

Commented by: Swiftb0y
Date: 2022-07-03T15:40:25Z


Fixed in #4835

@mixxxbot
Copy link
Collaborator Author

Commented by: per-terra
Date: 2022-07-28T11:11:06Z


Hello,

I'm new to Mixxx and using Numark DJ2GO2 Touch.
With the latest development version of the Mixxx, the tempo slider is still reversed.

When I add the "invert: true" option in the script, it works correctly.

From reading the pull request, it seems that the option was considered but eventually not adopted.

Why you didn't adopt the option?

Best regards,
Per-Terra.

@mixxxbot
Copy link
Collaborator Author

Commented by: ronso0
Date: 2022-07-28T12:07:18Z


You didn't yet answer that question:
Have you looked at Preferences > Decks > Speed > Slider range > Down Increases Speed?

@mixxxbot
Copy link
Collaborator Author

Issue closed with status Fix Committed.

@mixxxbot mixxxbot transferred this issue from another repository Aug 24, 2022
@mixxxbot mixxxbot added this to the 2.3.4 milestone Aug 24, 2022
@doteya
Copy link
Contributor

doteya commented Sep 1, 2022

I find that the reversed Tempo-Fader issue is not resolved.
"Down increases speed" is checked, the HW tempo-fader down makes slider UI up and decrease speed.
DJ2GO2_DownIncreasesSpeed

"Down increases speed" is unchecked, the HW tempo-fader down makes slider UI up and increase speed.
DJ2GO2_UpIncreasesSpeed

I think that "invert: true" is required for Tempo-Fader Pots.
I will make PR for it.

And other issue, Miss translated "Down increases speed" to Japanese.
In Japanese, the check box label means "Down decreases speed".
I will check how to fix translation.

Latest 2.4 alpha fixed this.

doteya added a commit to doteya/mixxx that referenced this issue Sep 1, 2022
Fix the inverted tempo fader moving issue.
Part of issue mixxxdj#10586 (lp1948596).
@ronso0 ronso0 reopened this Sep 1, 2022
@ronso0
Copy link
Member

ronso0 commented Sep 1, 2022

@doteya Just to be sure: you tested with the latest 2.3 beta (2.3.4), not with tge current stable 2.3.3?

@doteya
Copy link
Contributor

doteya commented Sep 1, 2022

@ronso0 Now I test latest 2.3 beta and stable 2.3.3 on Windows 11.
They have the same problem.
Latest version can change "Down increases speed" to increase/decrease speed like HW label, but inverted direction of UI problem is not resolved.

@doteya
Copy link
Contributor

doteya commented Sep 1, 2022

@ronso0 Please let me add more information.
My tested environment was not the latest 2.3 beta build.
I overwrote c:\program files\mixxx\controllers with res/controllers, and deleted c:\users\myuser\AppData\Local\MIXXX.
So I have tested stable 2.3.3 build with latest Numark DJ2Go2 midi map, scripts and midi-components-0.0.js.

@ronso0
Copy link
Member

ronso0 commented Sep 1, 2022

Okay.
if an issue is only about a particular mapping (as long as the Mixxx base version is the same 2.3.3+, and midi-components is not involved) you don't need to mess with directories but simply copy the 2.3.4 mapping files (midi and script) to your user settings directory /controllers so it's shown in the upper section of the mapping list in the controller preferences

@doteya
Copy link
Contributor

doteya commented Sep 1, 2022

Thank you.
I will test by using the user folder in the next time.

@daschuer
Copy link
Member

daschuer commented Feb 5, 2023

What is the status of this issue?

@daschuer daschuer removed this from the 2.3.4 milestone Feb 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants