Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search bar: LibraryTableModel::select() invoked for each control key press #11287

Closed
uklotzde opened this issue Feb 20, 2023 · 2 comments
Closed

Comments

@uklotzde
Copy link
Contributor

Bug Description

Each key press of a cursor key immediately triggers a new search, ignoring the configured timeout:

debug [Main] LibraryTableModel(0x1af5c60) select() took 1485 ms 42
debug [Main] LibraryTableModel(0x1af5c60) select() took 1460 ms 42
debug [Main] LibraryTableModel(0x1af5c60) select() took 1471 ms 42
debug [Main] LibraryTableModel(0x1af5c60) select() took 1471 ms 42
debug [Main] LibraryTableModel(0x1af5c60) select() took 1468 ms 42
debug [Main] LibraryTableModel(0x1af5c60) select() took 1463 ms 42
debug [Main] LibraryTableModel(0x1af5c60) select() took 1661 ms 42
debug [Main] LibraryTableModel(0x1af5c60) select() took 1716 ms 42
debug [Main] LibraryTableModel(0x1af5c60) select() took 1639 ms 42
debug [Main] LibraryTableModel(0x1af5c60) select() took 1493 ms 42
debug [Main] LibraryTableModel(0x1af5c60) select() took 1493 ms 42
debug [Main] LibraryTableModel(0x1af5c60) select() took 1529 ms 42
debug [Main] LibraryTableModel(0x1af5c60) select() took 1558 ms 42
debug [Main] LibraryTableModel(0x1af5c60) select() took 1627 ms 42

If you make a typo you have to clear the search bar and try again. Unusable.

Version

main

OS

Linux

@uklotzde uklotzde added the bug label Feb 20, 2023
@uklotzde
Copy link
Contributor Author

Also affects 2.3 and 2.4: e25071d

uklotzde referenced this issue Feb 20, 2023
…on required -> or enter to become active.

This fixes #10977
daschuer added a commit to daschuer/mixxx that referenced this issue Feb 20, 2023
… removed.

This fixes a regression described in issue mixxxdj#11287
@daschuer
Copy link
Member

Also affects 2.3 and 2.4

Our stable 2,3 branch is luckily not affected.
A Fix can be found here: #11289

daschuer added a commit to daschuer/mixxx that referenced this issue Feb 21, 2023
… removed.

This fixes a regression described in issue mixxxdj#11287
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants