Sync Leader (Crown)-Button changes tempo of deck

[JoergAtGithub]

Bug Description

When I've two decks playing out of sync and click on the crown button, I expect that this deck become sync leader and keeps it's tempo - but it takes over the tempo of the other deck, which is not synced.

tempo_of_deck_jumps_when_making_it_sync_leader.mp4

Version

2.4

OS

Windows 11

[Holzhaus]

Pinging @ywwg as he is the Sync expert 🙂

[ywwg]

This is a regression because we had to punt on proper Explicit Sync Leader support in 2.4 (which caused too many bugs for us to include). Normally when sync is enabled, there's an algorithm to pick a sync target -- by default, this is always another track, because the idea is that the user has pressed the sync button on one deck to match the bpm of another deck. But when enabling Leader specifically, this should not happen. I believe I can fix this.

[ywwg]

pr posted

[daschuer]

Thank you