Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preferences: Incomplete version check and update #9709

Closed
mixxxbot opened this issue Aug 23, 2022 · 2 comments
Closed

Preferences: Incomplete version check and update #9709

mixxxbot opened this issue Aug 23, 2022 · 2 comments
Labels
bug confirmed easy preferences

Comments

@mixxxbot
Copy link
Collaborator

Reported by: uklotzde
Date: 2019-08-09T09:30:35Z
Status: Confirmed
Importance: Low
Launchpad Issue: lp1839599
Tags: easy, preferences

The version check in preferences/upgrade.cpp is incomplete and doesn't work as expected. Often users will see the following warning when starting Mixxx:

Warning [Main]: Configuration file is at version "2.2.1" instead of the current 2.2.2

TODO:

  • Upgrade version if no special action is required, not only for selected but for all future versions by default to avoid that this warning reappears.
  • Never downgrade the version! This requires parsing and comparing version numbers, which is currently missing.

References:
https://mixxx.zulipchat.com/#narrow/stream/109171-development/topic/Release.202.2E2.2E2.20-.20Help.20needed/near/172836944
@mixxxbot
Copy link
Collaborator Author

Commented by: nopeppermint
Date: 2019-08-09T12:03:08Z

#2231

@mixxxbot
Copy link
Collaborator Author

Commented by: nopeppermint
Date: 2019-08-09T12:13:39Z

as this should also go into 2.1.x I created a new PR: #2232

@mixxxbot mixxxbot mentioned this issue Aug 24, 2022
Closed
@mixxxbot mixxxbot transferred this issue from another repository Aug 24, 2022
This was referenced Jan 28, 2023
Closed
Merged
daschuer added a commit that referenced this issue Jan 30, 2023
@daschuer
Merge pull request #11229 from CaptainSifff/2.3
7e4b25d 
 Fix: Preferences: Incomplete version check in 2.3 and update #9709
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug confirmed easy preferences
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: Preferences: Incomplete version check and update #9709 CaptainSifff/mixxx
2 participants
@daschuer @mixxxbot