Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(soundsourceffmpeg): Fix compatibility with FFmpeg 5.1 [WIP] #10857

Closed
wants to merge 1 commit into from

Conversation

Holzhaus
Copy link
Member

@Holzhaus Holzhaus commented Sep 1, 2022

Fixes #10856.

TODO:

  • Use ifdefs to maintain compatibility with older ffmpeg versions
  • Find bug that causes two tests to segfault:
The following tests FAILED:
	697 - SoundSourceProxyTest.seekForwardBackward (SEGFAULT)
	699 - SoundSourceProxyTest.seekBoundaries (SEGFAULT)

If someone wants to take over, feel free to do so. I don't know when I'll find the time to continue working on this.

@uklotzde
Copy link
Contributor

uklotzde commented Sep 1, 2022

Thanks, Jan. I have already re-added the deleted code behind version flags. Would have been easier to do this before rewriting/deleting. No time to test yet.

@uklotzde
Copy link
Contributor

uklotzde commented Sep 2, 2022

Unfortunately, the Mixxx build fails when using the custom FFmpeg static libs due to undefined symbols in libavcodec. Worked for 5.0. Might try later, no prio.

@Holzhaus Holzhaus closed this Sep 5, 2022
@Holzhaus Holzhaus deleted the update-soundsourceffmpeg-5.1 branch September 5, 2022 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix compatibility with FFmpeg 5.1
2 participants