Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup: Require FFmpeg v4.1.9 or later #10866

Merged
merged 1 commit into from
Sep 3, 2022
Merged

Cleanup: Require FFmpeg v4.1.9 or later #10866

merged 1 commit into from
Sep 3, 2022

Conversation

uklotzde
Copy link
Contributor

@uklotzde uklotzde commented Sep 3, 2022

  • Require FFmpeg v4.1.9 as the minimum version
  • Consistently use AV_VERSION_INT >= minimum_version
  • Delete dead code

@uklotzde
Require FFmpeg v4.1.9 or later
8b97df0 
- Require FFmpeg v4.1.9 as the minimum version
- Consistently use AV_VERSION_INT >= minimum_version
- Delete dead code
@github-actions github-actions bot added the build label Sep 3, 2022
@uklotzde
Copy link
Contributor Author

uklotzde commented Sep 3, 2022

@Holzhaus Follow-up of #10856 to get rid of old cruft.

If the CI builds succeed all changes are safe. The pre-commit failure seems unrelated.

Holzhaus
Holzhaus approved these changes Sep 3, 2022
View reviewed changes
Copy link
Member

@Holzhaus Holzhaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@Holzhaus
Copy link
Member

Holzhaus commented Sep 3, 2022

I also verified that Ubuntu 20.04 ships FFmpeg 4.2, so this should be no problem.

@Holzhaus Holzhaus merged commit 55a8272 into mixxxdj:2.3 Sep 3, 2022
@uklotzde uklotzde deleted the ffmpeg-4.1.9 branch September 3, 2022 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Holzhaus Holzhaus Holzhaus approved these changes

Assignees
No one assigned
Labels
build
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@uklotzde @Holzhaus