Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): upgrade macos CI to fix failing builds because of missing postgresql dependency #10872

Merged
merged 2 commits into from
Sep 7, 2022

Conversation

Swiftb0y
Copy link
Member

@Swiftb0y Swiftb0y commented Sep 6, 2022

Windows upgrade is missing because build is still running.

@github-actions github-actions bot added the build label Sep 6, 2022
@Swiftb0y Swiftb0y marked this pull request as ready for review September 6, 2022 23:51
@Swiftb0y
Copy link
Member Author

Swiftb0y commented Sep 7, 2022

all CI green again, yeah 🎉

Copy link
Member

@daschuer daschuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great thank you. Full force ahead to the 2.4-beta.

set(VCPKG_TARGET_TRIPLET "x64-osx-min10.12")
set(VCPKG_TARGET_TRIPLET "x64-osx-min1012")
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm kinda iffy about this required change. Any opinion @Be-ing, @Holzhaus?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change was required because it was required to fix a build error after merging upstream. This commit:

mixxxdj/vcpkg@fb78450

Copy link
Member Author

@Swiftb0y Swiftb0y Sep 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mhmm ok, thanks for clarifying.

@daschuer daschuer merged commit 9ad1047 into mixxxdj:main Sep 7, 2022
@ronso0 ronso0 added this to the 2.4.0 milestone Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants