Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WSpinny: ensure DlgCoverArtFullSize has a parent on xcb #10973

Merged
merged 1 commit into from
Oct 19, 2022
Merged

WSpinny: ensure DlgCoverArtFullSize has a parent on xcb #10973

merged 1 commit into from
Oct 19, 2022

Conversation

ronso0
Copy link
Member

@ronso0 ronso0 commented Oct 16, 2022 •
edited
Loading

see #10968

regression from b8dff32#diff-b1b61c8dfee6e1e996c68cbc327f3c9f1654f5426ef92265550fe6775432c0e8R1281 on xcb
WSpinny is created with nullptr parent and that is used to create DlgCoverArtFullSize. When the parent is set for WSpinny it is not set for DlgCoverArtFullSize.

Alternative: 78644e4

Closing #10968

@github-actions github-actions bot added the ui label Oct 16, 2022
@ronso0 ronso0 added regression and removed ui labels Oct 16, 2022
@ronso0 ronso0 added this to the 2.3.4 milestone Oct 16, 2022
@ronso0
Copy link
Member Author

ronso0 commented Oct 16, 2022

@daschuer Please take a look.

@ronso0 ronso0 linked an issue Oct 17, 2022 that may be closed by this pull request
Debug assert hit in DlgCoverArtFullSize #10968
Open
@ronso0
Copy link
Member Author

ronso0 commented Oct 18, 2022

*ping
please take a look soon, I can't use current 2.3 or main like this and need to apply this patch to every branch.

@ronso0 ronso0 mentioned this pull request Oct 18, 2022
Merged
daschuer
daschuer approved these changes Oct 19, 2022
View reviewed changes
Copy link
Member

@daschuer daschuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I see. LGTM, Thank you.

@daschuer
Copy link
Member

And works as well.

@daschuer daschuer merged commit bd3f5ea into mixxxdj:2.3 Oct 19, 2022
@ronso0 ronso0 deleted the wspinny-coverart-parent branch October 19, 2022 09:08
napaalm added a commit to napaalm/mixxx that referenced this pull request Mar 23, 2023
@napaalm
Revert "Merge pull request mixxxdj#10973 from ronso0/wspinny-coverart…
90ab354 
…-parent"

This reverts commit bd3f5ea, reversing
changes made to 4b0f8a2.
napaalm added a commit to napaalm/mixxx that referenced this pull request Mar 23, 2023
@napaalm
Revert "Merge pull request mixxxdj#10973 from ronso0/wspinny-coverart…
ad492a5 
…-parent"

This reverts commit bd3f5ea, reversing
changes made to 4b0f8a2.
napaalm added a commit to napaalm/mixxx that referenced this pull request Mar 23, 2023
@napaalm
Revert "Merge pull request mixxxdj#10973 from ronso0/wspinny-coverart…
f5472f4 
…-parent"

This reverts commit bd3f5ea, reversing
changes made to 4b0f8a2.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daschuer daschuer daschuer approved these changes

Assignees
No one assigned
Labels
regression
Projects
None yet
Milestone
2.3.4
Development

Successfully merging this pull request may close these issues.

Debug assert hit in DlgCoverArtFullSize
2 participants
@ronso0 @daschuer