-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add warning when trying to enable AutoDJ with left & right deck #11018
Conversation
Please stop opening new PRs, instead follow the instructions @daschuer and I gave you and fix the original PR. This is actually trivial given the small change set. To be continued in #11013 |
@ronso0 Sorry about that I will not repeat my mistakes again, I understood the problem and the pre-commit was causing it I don't know how. But at the time of commit normally it ask for password, but while using pre-commit it doesn't ask any password, that's why it is causing errors |
@ronso0 You can check this request for the checks If any error will occur I will restudy the whole github and then I will start contributing to this community |
Pre-commit is still failing since the indentations don't match. |
@ronso0 I have installed it already. Ok I will fix this completely first then I will try to commit or to push a request thank you very much |
@ronso0 I am sorry to disturb you again but I was looking for this from nearly 4 hours now still cant find a way to fix it The pre-commit is giving this output: It doesn't fixing the format just getting closed immediately after this I checked git status as well no changes are show |
You obviously didn't bother to read the command output. Below the red Failed it says |
There is work in progress to make pre-commit on windows more robust. Please
Unfortunately this will combine the two PRs, but I can clean that up before merge. |
You may also report your experience in the original PR that we get it merged soon: |
Ok, sorry, didn't know this is a known issue on Windows. |
@ronso0 I have followed all the steps as you followed |
Okay, finally LGTM This is a good first step. Later on it would be nice to show a message when assign switches are changed while AutoDJ is running. Though I think this is out o scope here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Thank you for your endurance!
Before merge, we need your permission to distribute the code with Mixxx.
Please sign https://docs.google.com/a/mixxx.org/spreadsheet/viewform?formkey=dEpYN2NkVEFnWWQzbkFfM0ZYYUZ5X2c6MQ and comment here when done. Thank you.
@daschuer Done |
LGTM= Looks good to me |
Added warning message when trying to enable AutoDJ if there's no left & right deck.