Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DlgPrefEffects: restore list selection only if FocusIn reason is keyboard #11055

Merged
merged 2 commits into from
Dec 8, 2022

Conversation

ronso0
Copy link
Member

@ronso0 ronso0 commented Nov 9, 2022

restoring the selection while using the keyboard works fine, though mouse clicks sent to unfocused lists that

  • had an item selected previously and
  • were scrolled afterwards without being focused

would select the wrong index.


Test main:

  • go to Pref > Effects, choose chain or visible tab and
  • make sure the scrollbars popup in one of the lists (decrease window height if list is too short)
  • click topmost item in scrollable list
  • click any item in adjacent list = selection in scrollable list is cleared
  • scroll down scrollable list (don't click)
  • select any item in that list
    = wrong item is selected

@ronso0 ronso0 added this to the 2.4.0 milestone Nov 9, 2022
@ronso0 ronso0 changed the title DlgPreEffects: restore list selection only if FocusIn reason is keyboard DlgPrefEffects: restore list selection only if FocusIn reason is keyboard Nov 9, 2022
@github-actions github-actions bot added the ui label Nov 9, 2022
…oard

Otherwise mouse clicks sent to unfocused lists that were scrolled previously
would select the wrong index.
@ronso0 ronso0 force-pushed the eff-pref-list-focusin-selection branch from f4937d2 to 0f69b65 Compare November 9, 2022 11:20
@ronso0
Copy link
Member Author

ronso0 commented Dec 4, 2022

ping @daschuer

Copy link
Member

@daschuer daschuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ups, thank you for the reminder.
LGTM

@daschuer daschuer merged commit 5ddd671 into mixxxdj:main Dec 8, 2022
@ronso0 ronso0 deleted the eff-pref-list-focusin-selection branch December 8, 2022 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants