-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Effect parameter label: set hand cursor to make dragability more discoverable #11062
Conversation
Thank you, it works as proposed. The CI failure is unrelated. While I am not against merging this, I am unsure if this is actually an improvement. The rare "sorting the parameter use case" is now very prominent. Here on Ubuntu Focal, it is already the closed hand, shown during dragging. What do others think? |
Yes, the behaviour while dragging is already fine.
Yes, but at least that (as well as double-click and right-click) is mentioned in the tooltip. I think you perceive the hand cursor for fx params is 'prominent' because currently we don't use context cursors anywhere else. Another candidate is the text cursor for spinboxes and the searchbox. |
I am still unsure about this. Can anyone else test this and share the opinion? |
Just an idea regarding discoverability and maybe "What's new?", dunno if that's overkill: Note I won't fight for this being merged, but IMO it's the best option atm to make this new feature visible. Very few users seem to read the manual, I bet even those won't read it again after an update. So we should add that to the manual, but I doubt it helps much. Squeezing this into every parameter tooltip seems overkill, but maybe we should do that instead, idk. |
In general I agree that we should make drag and drop more discoverable. My hesitations in the case here are sourced by the issue that sorting the parameters is only a one time task. Is there a way to solve both? |
I understand the distraction aspect, but the pointer will only change if you hover the parameter name. |
Can you rebase this on master. I think this should fix the Qt 6.3 build. |
IMO this is an improvement, though I'm confused why you are asking for my opinion on this particular feature. |
e3c608e
to
d843207
Compare
Thank you for confirming. I was just looking for a second unbiased opinion. |
No description provided.