Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrap selection around at the bottom/top of the library's tracks list #11090

Merged
merged 4 commits into from
Dec 8, 2022
Merged

Wrap selection around at the bottom/top of the library's tracks list #11090

merged 4 commits into from
Dec 8, 2022

Commits on Nov 23, 2022

  1. Restore wraparound in [Library],MoveVertical 

    This makes navigating key-sorted track lists using a controller much
more convenient. Though as mentioned in the comment, this does not match
the Up/Down cursor key behavior. Should those also wrap around?
    @robbert-vdh
    robbert-vdh committed Nov 23, 2022
    Configuration menu
    Copy the full SHA
    dc83783 View commit details
    Browse the repository at this point in the history

  2. Also wrap library list around with cursor movement 

    This matches the new(ly restored) behavior from
dc83783 by overriding `QTableView`'s
`moveCursor()` function. This way this also works as expected with the
other common selection hotkeys like Shift+Up/Down and Ctrl+Up/Down ->
Space.
    @robbert-vdh
    robbert-vdh committed Nov 23, 2022
    Configuration menu
    Copy the full SHA
    9268309 View commit details
    Browse the repository at this point in the history

  3. Reuse new cursor key handler in MoveVertical 

    The event handler for `WLibraryTableView` now also wraps around the list
when navigating it using the cursor keys. So `[Library],MoveVertical`
can revert to just sending Up/Down key events to the
`WLibraryTableView`.
    @robbert-vdh
    robbert-vdh committed Nov 23, 2022
    Configuration menu
    Copy the full SHA
    1f4088f View commit details
    Browse the repository at this point in the history

  4. Handle moving invalid WLibraryTableView cursor 

    This happens when the view has not yet been interacted with.
    @robbert-vdh
    robbert-vdh committed Nov 23, 2022
    Configuration menu
    Copy the full SHA
    11f5f89 View commit details
    Browse the repository at this point in the history