Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tracks table: fix initial track selection with BackTab #11130

Merged
merged 1 commit into from
Jan 4, 2023
Merged

Tracks table: fix initial track selection with BackTab #11130

merged 1 commit into from
Jan 4, 2023

Conversation

ronso0
Copy link
Member

@ronso0 ronso0 commented Dec 16, 2022 •
edited
Loading

on main with assertion_fatal enabled

  • start Mixxx
  • Ctrl+F to focus searchbar
  • Shift+Tab to jump to tracks
  • hit DEBUG_ASSERT(selectionModel()->isSelected(currentIndex()));
  • = top left item focused but not selected

Doesn't happen in 2.3, idk what's causing this regression.

@github-actions github-actions bot added the ui label Dec 16, 2022
@ronso0 ronso0 added this to the 2.4.0 milestone Dec 16, 2022
daschuer
daschuer approved these changes Jan 4, 2023
View reviewed changes
Copy link
Member

@daschuer daschuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thank you.

@daschuer daschuer merged commit 437bd78 into mixxxdj:main Jan 4, 2023
@ronso0 ronso0 deleted the trackstable-first-backtab-focus branch January 4, 2023 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daschuer daschuer daschuer approved these changes

Assignees
No one assigned
Labels
bug library regression
Projects
None yet
Milestone
2.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ronso0 @daschuer