Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed regression in coverart tooltip - The assert occured always #11153

Merged
merged 1 commit into from
Dec 24, 2022

Conversation

JoergAtGithub
Copy link
Member

This fixes a regression for QT>=5.14 introduced in #4309

If you move the mouse over a cover art in the library, the tool tip should appear, but due to this regression it always asserted. The function parent() returns always nullptr.

Stacktrace:

Qt5Core.dll!00007ffaae1e0598()
Qt5Core.dll!00007ffaae1de80d()
mixxx.exe!mixxx::`anonymous namespace'::handleMessage(QtMsgType type, const QMessageLogContext & context, const QString & input) Line 355
	at C:\Users\Joerg.WORLDWARTWEB\source\repos\JoergAtGithub\mixxx\src\util\logging.cpp(355)
[External Code]
[Inline Frame] mixxx.exe!mixxx_debug_assert(const char *) Line 9
	at C:\Users\Joerg.WORLDWARTWEB\source\repos\JoergAtGithub\mixxx\src\util\assert.h(9)
[Inline Frame] mixxx.exe!mixxx_debug_assert_return_true(const char *) Line 18
	at C:\Users\Joerg.WORLDWARTWEB\source\repos\JoergAtGithub\mixxx\src\util\assert.h(18)
mixxx.exe!BaseTrackTableModel::composeCoverArtToolTipHtml(const QModelIndex & index) Line 521
	at C:\Users\Joerg.WORLDWARTWEB\source\repos\JoergAtGithub\mixxx\src\library\basetracktablemodel.cpp(521)
mixxx.exe!BaseTrackTableModel::roleValue(const QModelIndex & index, QVariant && rawValue, int role) Line 573
	at C:\Users\Joerg.WORLDWARTWEB\source\repos\JoergAtGithub\mixxx\src\library\basetracktablemodel.cpp(573)
mixxx.exe!BaseTrackTableModel::data(const QModelIndex & index, int role) Line 436
	at C:\Users\Joerg.WORLDWARTWEB\source\repos\JoergAtGithub\mixxx\src\library\basetracktablemodel.cpp(436)
[External Code]
mixxx.exe!`anonymous namespace'::runMixxx(MixxxApplication * pApp, const CmdlineArgs & args) Line 72
	at C:\Users\Joerg.WORLDWARTWEB\source\repos\JoergAtGithub\mixxx\src\main.cpp(72)
mixxx.exe!main(int argc, char * * argv) Line 200
	at C:\Users\Joerg.WORLDWARTWEB\source\repos\JoergAtGithub\mixxx\src\main.cpp(200)
[External Code]

Copy link
Member

@daschuer daschuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Looks and works good.

@daschuer daschuer merged commit 3a1902b into mixxxdj:main Dec 24, 2022
@JoergAtGithub JoergAtGithub deleted the regressionFixCoverArtToolTip branch December 24, 2022 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants