Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Library Layout Redesign Single pane #1117

Closed
wants to merge 799 commits into from
Closed

Library Layout Redesign Single pane #1117

wants to merge 799 commits into from

Conversation

daschuer
Copy link
Member

@daschuer daschuer commented Jan 12, 2017 •
edited
Loading

Hi this is a continuation of #991 and #1115 with the changes made and to do:

  • Single pane visualization
  • Fix bug with playlists
  • Fix merge conflicts @jmigual
  • polish Auto DJ pane
  • Auto DJ crate icon is not colored @daschuer
  • Deere's preview player is not recognizable as "player" if it is empty
  • No filter (Search) in browse feature
  • crasher changing from browse to library view (not reproducible for now)
  • playlists feature shows the IDs instead of the name when you select that feature
  • rename browse feature
  • rename library feature Icon update #1119

daschuer and others added 30 commits October 12, 2016 22:05
@daschuer
Keyboard control in WLibrarySidebar improved
440d458
@jmigual
Merge pull request #2 from daschuer/libraryFocus
70ed385 
Enable keybord navigation for the search box.
@jmigual
Merge branch 'feature/libraryTree'
78a56f7 
Conflicts:
	src/widget/wsearchlineedit.h
@jmigual
Fix warning about unused variable
3800e89
@jmigual
Fix sort order in pinned queries
73fcdaf
@jmigual
Add pinned icon to queries
6b11a85
@jmigual
Merged branch feature/savedQueries into feature/libraryTree
0e229e0
@jmigual
Merge branch 'master'
b8838c2 
Conflicts:
	src/library/library.h
@daschuer
Fix selected row background for cover and preview buttion
2c2f13e
@daschuer
Do not highlight table header
2b83603
@daschuer
Fix selection style in Treeview of LateNight
20e3143
@daschuer
Skip header when scrolling by up/down
3fe2902
@jmigual
Merge branch 'daniel/master' into feature/libraryTree
96f0d6d
@jmigual
Merge master
23756c5 
Conflicts:
src/library/features/playlist/playlisttablemodel.cpp
src/library/features/playlist/playlisttablemodel.h
src/library/basesqltablemodel.h
@jmigual
Remove foreach
be6b81d
@jmigual
Fix some compilation issues
ac00985
@daschuer
Added new image for locked preselect button
f02a996
@jmigual
Fix build
645cd28
@jmigual
Merge pull request #3 from daschuer/libraryFocus
8d539cd 
Library focus
@daschuer
LibrarySidebarExpanden now moved the preselected button as well
755afc4
@daschuer
joined featurePane and SavedPane, this allows better control for the …
0cb8452 
…plylist panes
@daschuer
Invalidate stored Index when skin is changing, fixes a crasher.
d05ec06
@daschuer
Fix invalid restoreSearch during skin setup
79d4876
@daschuer
Avoid to create the library base track chache twice.
4e97415
@daschuer
Remove unnecessary Assert
993e87b
@daschuer
Improved Deere syling a bit
696d5d3
@daschuer
Add focus borders to Shade skin
6efa706
@jmigual
Merge remote-tracking branch 'mixxxdj/master' into feature/libraryTree
8f6035f
@jmigual
Fix windows compilation
e98b719
@daschuer
Silence some debug messages
84f1929
@daschuer
Copy link
Member Author

conflicts resolved.

@ronso0
Copy link
Member

ronso0 commented Jun 13, 2018

It crashes trying to switch to Tango now

It appears to be related to waveforms: if I exclude everything waveform related it runs fine.
I'll try to figure out what's wrong.

@ronso0
Copy link
Member

ronso0 commented Jun 13, 2018

Last warning I see before it crashes:
Warning [Main]: QPaintDevice: Cannot destroy paint device that is being painted

@ronso0
Copy link
Member

ronso0 commented Jun 13, 2018

Apart from that, pretty much everything is super slow the first few minutes after start:
startup itself, skin change, 1st track load, analysis when loading a track, shutdown

@ronso0
Copy link
Member

ronso0 commented Jun 14, 2018

Apart from that, pretty much everything is super slow the first few minutes after start

Seems to be caused by my large library, with a clean profile everything is as fast as with previous lib-redesign builds.

@ronso0
Copy link
Member

ronso0 commented Jun 14, 2018 •
edited
Loading

Deere crashes when I try to

  • toggle stacked waveforms
  • show 4 decks
  • show samplers

It does NOT crash when I manually set the samplers visible in config, then start Mixxx and toggle them on/off/on/off. However, it DOES crash when I try to change the number of sampler rows.

Good thing: shutdown of Deere with 64 samplers is as quick as the 16-samplers version (with all 64 samplers manually enabled in cfg and ~20 samplers loaded) so we may revert the respective skin hack when the above issues are solved.

@Be-ing
Copy link
Contributor

Be-ing commented Jun 17, 2018

@ronso0 vector images for the library icons are in res/images/templates/ic_template_library_and_preferences.svg. If you could take care of replacing the PNG images with SVGs that would be nice. The PNG icons look blurry on my screen.

@ronso0
Copy link
Member

ronso0 commented Jun 20, 2018

@Be-ing Yes, I can take care of the icons. Do you the reason some of them are offset to the left?

@nopeppermint nopeppermint mentioned this pull request Jun 20, 2018
Merged
@Be-ing
Copy link
Contributor

Be-ing commented Jun 22, 2018

'Load track to deck X' only works in Tracks view, not in Crates, Playlists & History.

I'm not sure what you mean. Loading tracks via the right click context menu works fine in all features for me. However, the LoadSelectedTrack and LoadSelectedTrackAndPlay ControlObjects don't do anything.

Mixxx crashes when I issue [Library],GoToItem

I can reproduce this.

Mixxx crashes when I right-click into empty scroll area in AutoDJ > Track source

Fixed in #1720

These are the only remaining merge blockers, correct? Is there anything I am missing?

@ronso0
Copy link
Member

ronso0 commented Jun 23, 2018

'Load track to deck X' only works in Tracks view, not in Crates, Playlists & History.

I'm not sure what you mean. Loading tracks via the right click context menu works fine in all features for me. However, the LoadSelectedTrack and LoadSelectedTrackAndPlay ControlObjects don't do anything.

Yes, I referred to the COs used by controllers

These are the only remaining merge blockers, correct? Is there anything I am missing?

What about

The UI sluggishness is way more severe than I remember

IMO this renders Mixxx pretty much useless with a large library

@Be-ing
Copy link
Contributor

Be-ing commented Jun 23, 2018 •
edited
Loading

The GUI sluggishness was fixed by #1714.

It looks like [Library], GoToItem was broken by merging master after #1560 was merged to master. I'm quite confused what the code for LibraryControl::slotGoToItem should be at this point and the code in this branch in general is really confusing. I can't even tell what code classes correspond to what I see on screen.

@Be-ing
Copy link
Contributor

Be-ing commented Jun 23, 2018

Travis reports that the macOS build is broken.

@Be-ing Be-ing mentioned this pull request Jun 23, 2018
Closed
@Be-ing Be-ing changed the title [WIP] Library Layout Redesign Single pane Library Layout Redesign Single pane Jun 23, 2018
@nopeppermint nopeppermint mentioned this pull request Jun 24, 2018
Merged
uklotzde
uklotzde suggested changes Jun 24, 2018
View reviewed changes
Copy link
Contributor

@uklotzde uklotzde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Next try with a clean build based on Qt5 (5.10.1), pulling the latest changes from master.

Unfortunately the same results as reported earlier. I experience an extended startup time and even more severe lags during operation. The UI is very sluggish when browsing the library or selecting tracks and freezes for an extended period of half a minute or even longer when loading tracks. Sorry, but this is totally unusable. It is not sufficient to test with a fresh and almost empty database containing just a few thousand tracks.

I strongly recommend NOT merging these changes until at least the major usability issues have been fixed. We won't be able to fix any serious design flaws when discovered during the beta phase. I suppose there are some.

@Be-ing
Copy link
Contributor

Be-ing commented Jun 24, 2018

@uklotzde did you test upstream/jmigual-library-redesign or @daschuer's branch? It looks like @daschuer has not merged the recent fixes into his branch yet.

@Be-ing Be-ing mentioned this pull request Jun 24, 2018
Closed
3 tasks
@Be-ing
Copy link
Contributor

Be-ing commented Jun 24, 2018

I am closing this in favor of #1726 to avoid such confusion going forward.

@Be-ing Be-ing closed this Jun 24, 2018
This was referenced Aug 22, 2022
Open
Open
Open
Open
Open
Closed
Open
Closed
@daschuer daschuer mentioned this pull request Jan 30, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timrae timrae timrae left review comments

@jmigual jmigual jmigual left review comments

@Be-ing Be-ing Be-ing left review comments

@gramanas gramanas gramanas left review comments

@uklotzde uklotzde uklotzde requested changes

Assignees
No one assigned
Labels
library ui
Projects
None yet
Milestone
2.2.0
Development

Successfully merging this pull request may close these issues.