Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replay Gain Preferences: Fix the "adjust by" text in case of negative adjustments #11176

Merged
merged 1 commit into from
Jan 2, 2023
Merged

Replay Gain Preferences: Fix the "adjust by" text in case of negative adjustments #11176

merged 1 commit into from
Jan 2, 2023

Conversation

daschuer
Copy link
Member

@daschuer daschuer commented Jan 2, 2023

The value was missing in the negative case due to a typo with braces.

@daschuer daschuer added the bug label Jan 2, 2023
@github-actions github-actions bot added the ui label Jan 2, 2023
@daschuer daschuer added this to the 2.3.4 milestone Jan 2, 2023
@daschuer daschuer added the changelog This PR should be included in the changelog label Jan 2, 2023
@ronso0
Copy link
Member

ronso0 commented Jan 2, 2023

Thank you, LGTM
You've set the 2.3.4 milestone, so please rebase onto 2.3

@daschuer daschuer changed the base branch from main to 2.3 January 2, 2023 22:36
@daschuer
Copy link
Member Author

daschuer commented Jan 2, 2023

Oh yes. Done.

@ronso0
Copy link
Member

ronso0 commented Jan 2, 2023

ouh no rebase required? well..

@ronso0 ronso0 merged commit 01131b1 into mixxxdj:2.3 Jan 2, 2023
@daschuer daschuer deleted the lufs_gain_display branch May 4, 2023 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug changelog This PR should be included in the changelog ui
Projects
None yet
Milestone
2.3.4
Development

Successfully merging this pull request may close these issues.
2 participants
@daschuer @ronso0