Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unified range checking behavior for BeatJumpSize and BeatLoopSize between GUI-Widget and controller CO #11248

Merged
merged 6 commits into from
Mar 23, 2023
Merged

Unified range checking behavior for BeatJumpSize and BeatLoopSize between GUI-Widget and controller CO #11248

merged 6 commits into from
Mar 23, 2023

Commits on Feb 4, 2023

  1. Unified range checking behavior for BeatJumpSize and for BeatLoopSize… 

    … between GUI-Widget and controller CO, by moving the check from the widget to the engine.
    @JoergAtGithub
    JoergAtGithub committed Feb 4, 2023
    Configuration menu
    Copy the full SHA
    ffb3999 View commit details
    Browse the repository at this point in the history

  2. Fixed slotLoopHalve/Double

    @JoergAtGithub
    JoergAtGithub committed Feb 4, 2023
    Configuration menu
    Copy the full SHA
    8f35f9b View commit details
    Browse the repository at this point in the history

Commits on Feb 6, 2023

  1. Added test cases for the loopsize / beatjumpsize range check

    @JoergAtGithub
    JoergAtGithub committed Feb 6, 2023
    Configuration menu
    Copy the full SHA
    28d705d View commit details
    Browse the repository at this point in the history

Commits on Feb 18, 2023

  1. Use same limit source for beatJumpSize as for beaLoopSize

    @JoergAtGithub
    JoergAtGithub committed Feb 18, 2023
    Configuration menu
    Copy the full SHA
    b84fdac View commit details
    Browse the repository at this point in the history

  2. Added comments which describe the test steps and limits.

    @JoergAtGithub
    JoergAtGithub committed Feb 18, 2023
    Configuration menu
    Copy the full SHA
    20edf5e View commit details
    Browse the repository at this point in the history

Commits on Mar 23, 2023

  1. Removed uneeded workaround, for applying value in WBeatSpinBox::stepB… 

    …y in two steps
    @JoergAtGithub
    JoergAtGithub committed Mar 23, 2023
    Configuration menu
    Copy the full SHA
    a325712 View commit details
    Browse the repository at this point in the history