Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Library sidebar: allow moving focused index with Ctrl + Up/Down #11262

Closed
wants to merge 1 commit into from

Conversation

ronso0
Copy link
Member

@ronso0 ronso0 commented Feb 10, 2023

follow-up for #11208, just the last commit.

Move focused index with Ctrl + Up/Down. Left/Right also work without Ctrl.
It's now consistent with the track view, see #11100

I find it handy for browsing history playlists without mouse, like when I want to check which History logs contain a certain track (need to keep the current tracks view obviously). If I find an interesting setlog, I just press Enter/Return to load it.


Draft for now as it requires yet unreviewed #11208

@ronso0 ronso0 marked this pull request as ready for review May 25, 2023 11:17
@github-actions
Copy link

This PR is marked as stale because it has been open 90 days with no activity.

@github-actions github-actions bot added the stale Stale issues that haven't been updated for a long time. label Aug 24, 2023
@daschuer
Copy link
Member

The code looks good. Need to test. Can you resolve conflict, by rebase if you like.

@ronso0
Copy link
Member Author

ronso0 commented Aug 24, 2023

Yeah, will do.
I noticed a sidebar selection issue in my personal branch (with this branch merged) lately, but couldn't reproduce it, yet. I'll observe this and figure whether it's in 2.4 or this branch or only in my branch.

For me this is low prio currently, and IMO it can go to 2.4 at any time as bug fix because it restores consistency of tracks table & sidebar.
So I suggest you don't spend your valuable time on this one until I'm sure it's save. Don't want to introduce regressions with this fix that probably only very few users will discover anyway.

I'd rather appreciate if we could get #11527 (and #11695 as follow-up) merged asap.

@github-actions github-actions bot removed the stale Stale issues that haven't been updated for a long time. label Aug 25, 2023
@ronso0 ronso0 marked this pull request as draft October 17, 2023 09:08
Copy link

This PR is marked as stale because it has been open 90 days with no activity.

@github-actions github-actions bot added the stale Stale issues that haven't been updated for a long time. label Jan 16, 2024
@ronso0 ronso0 closed this Jul 8, 2024
@ronso0 ronso0 deleted the lib-sidebar-move-focus branch July 8, 2024 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
library skins stale Stale issues that haven't been updated for a long time. ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants