Fix a rounding issue is BpmControl::getBeatContext #11263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ty DEBUG_ASSERT in Beats::iteratorFrom
JoergAtGithub
requested changes
Feb 10, 2023
src/engine/controls/bpmcontrol.cpp
Outdated
| const mixxx::audio::FramePos otherPositionOfThisNextBeat = otherPosition + | ||
| thisSecs2ToNextBeat * otherBeats->getSampleRate() * | ||
| pOtherEngineBuffer->getRateRatio(); | ||
| // This original version has double precision issues (we kept it for documentation): |
There was a problem hiding this comment.
Instead of leaving the old code as comment, src/test/bpmcontrol_test.cpp should be extended by a testcase that detects the precision issue.
|
The test took me way more time than the fix because it was really hard to artificially trigger the asserts because it is really a LSB double issue. But OK now the test is in place. |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This causes a DEBUG_ASSERT in Beats::iteratorFrom()