avoid a zillion of "ciitical ... QNSWindow ... active key-value observers" #11265
Conversation
|
note that arch linux qt 6.3 failing has nothing to do with this change |
|
I will do that.
… On 11 Feb 2023, at 12:12, Daniel Schürmann ***@***.***> wrote:
@daschuer commented on this pull request.
In src/widget/wwidgetgroup.cpp:
> @@ -152,6 +147,15 @@ void WWidgetGroup::setup(const QDomNode& node, const SkinContext& context) {
if (pLayout) {
setLayout(pLayout);
+
+ if (layout == "stacked") {
In this case you may also/instead cache the result of the first string comparison in a boolean.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.
|
|
I tested this and I can confirm the issue to be present in 2.3 but for some reason its not in recent 2.4 builds (without this PR). |
|
8727cfc, at least the M1 build, still gives me the errors. |
|
@Swiftb0y that is surprising, I don't see anything in the diff between main and 2.4 that would explain that. I will checkout 2.4 and give it a try. |
|
@Swiftb0y I tried with 2.4 and I still get all the "critical error" messages. Anyway, I think this fix can be merged to main (and to 2.4) now. |
|
This is a small bugfix - if there's no technical reason against it, this should go into 2.3 branch. |
|
sure, just needs a rebase then. |
m0dB
force-pushed
the
avoid-kvo-errors
branch
from
6338c84
to
cf73eda
Compare
|
comment changed as suggested by @ronso0 . please merge. |
There seem to be no regression, so @m0dB please rebase onto 2.3, then we can merge this. |
…itical ... QNSWindow ... active key-value observers" errors on startup
m0dB
force-pushed
the
avoid-kvo-errors
branch
from
f781912
to
c58ceba
Compare
|
commits squashed and rebased on 2.3 |
|
@Swiftb0y merge? |
|
Thank you! |
Sorry, I've been busy the last couple days. |
move dummy widget creation in WWidgetGroup::setup after setLayout, to avoid a zillion of "ciitical ... QNSWindow ... active key-value observers" errors on startup, as discussed here: https://mixxx.zulipchat.com/#narrow/stream/109171-development/topic/lots.20of.20.22critical.22.20QNSWindow.20errors.20on.20startup