2.3.4 Release

[daschuer]

This is the final step for a release.

#11275 needs to be merged before.
And #4729 is nearly ready.

There is some more pending work:
https://github.com/mixxxdj/mixxx/pulls?q=is%3Aopen+is%3Apr+milestone%3A2.3.4
can we postpone all to 2.3.5?

[daschuer]

The checklist for this release is here: https://github.com/mixxxdj/mixxx/wiki/Minor-Release-Checklist

[ronso0]

regarding open PRs: since the milestone might not be set or correct I now use base:2.3 in the PR filter bar:
https://github.com/mixxxdj/mixxx/pulls?q=is%3Apr+is%3Aopen+base%3A2.3

[ronso0]

FWIW I'd love to squeeze #11259 into 2.3.4 but that requires some testing. Not too hard but cumbersome, at least for since I need to download & install some distros/DEs, which takes time.
Worst case would be to break the nenubar in fullscreen in some distro, compared to the current bug in Ubuntu 22.04 LTS (is this still mainstream nowadays?) where Space bar for maximizing library doesn't work after toggling fullscreen.

Question is if we really would release 2.3.5 soonish after the fix is confirmed to not break any of the major distros.

[JoergAtGithub]

#4729 Is ready for merge into 2.3 now, but someone needs to check if the contributor aggreement is signed.

[daschuer]

I have no objections to merge #11259 right away.
I do not expect a full testing on every exotic menu bar solution. And if there is any, it is only a matter of a view lines to fix it. Can you remove the draft state?

[JoergAtGithub]

mixxxdj/manual#484 needs to be merged before release -> Done

[daschuer]

Great, Thank you.
So can one take a final look at #11275 merge it and than merge this.
After that we have a release candidate that can be verified No. 2 of https://github.com/mixxxdj/mixxx/wiki/Minor-Release-Checklist

[daschuer]

I have just cleaned up the 2.3.4 milestone.

Next step after releasing 2.3.4 is the 2.4-beta. I am not sure if we will release a 2.3.5 during the beta phase, but it is still a good idea to target bug fix and mapping PRs to the 2.3 branch because that will produce usable stable development snapshots.
Than we can decide if we want a 2.3.5 any time before a stable 2.4.0.
Pending 2.3 PRs: https://github.com/mixxxdj/mixxx/pulls?q=is%3Apr+is%3Aopen+base%3A2.3

Is that OK? What do you think?

[JoergAtGithub]

Sounds good to me. Let's plan with a 2.3.5 release, and if 2.4 is ready earlier than expected, we can cancel the 2.3.5 release.

[ronso0]

Yeah, I'd say if there are 'enough' bugfixes merged to 2.3 even while 2.4-beta is already published it's worth another bugfix release. Who knows what'll come up during the beta period 😬

[daschuer]

Ready to merge 🎉

[ronso0]

Yeaijy!
now we need the blog post..

[ronso0]

I'm looking at https://github.com/mixxxdj/website/pull/272/files right now, but tbh I'm not in the mood for prosa.
Will see if I can get that done over the weekend, or someone else takes a stab at it.

[daschuer]

Merging this creates a release candidate. So we can merge this IMHO merge this independent from anything else. The actual release happens after setting the release date and the Git tag.

[daschuer]

Can one press merge? We need some time for testing the release candidates.

[JoergAtGithub]

I checked the Windows version string in the About box. It's the same as in the .msi filename.

[JoergAtGithub]

Thank you!