Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tango: remove VU peak indicators from stacked layout #11430

Merged
merged 1 commit into from
Apr 3, 2023

Conversation

ronso0
Copy link
Member

@ronso0 ronso0 commented Apr 1, 2023

fixes blank WVUMeterGL and stuck peak indicator in stacked layout

Closes #11362

@github-actions github-actions bot added the skins label Apr 1, 2023
@ronso0
Copy link
Member Author

ronso0 commented Apr 1, 2023

I'll also make the small peak indicators white so they stand out more

@ronso0 ronso0 linked an issue Apr 1, 2023 that may be closed by this pull request
@ronso0 ronso0 changed the title Tango: put VU meters & peak indicators in horizontal layout Tango: remove VU peak indicators from stacked layout Apr 2, 2023
@ronso0
Copy link
Member Author

ronso0 commented Apr 2, 2023

I'll also make the small peak indicators white so they stand out more

no, I think this is fine as it is.
Ready to be merged. @daschuer Could you test this please?

(I'll force-push soon to separate include the removal of some obsolete VU SVG files)

Copy link
Member

@daschuer daschuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks and works good. Thank you.

@daschuer daschuer merged commit d5d9dc5 into mixxxdj:2.3 Apr 3, 2023
@daschuer daschuer added this to the 2.3.5 milestone Apr 3, 2023
@ronso0 ronso0 deleted the tango-vu-fix branch April 3, 2023 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VU meter broken in Tango, Mixxx 2.3.4
2 participants