This fixes Auto DJ stop after the track lengh changed #11479
Conversation
daschuer
force-pushed
the
gh11448
branch
2 times, most recently
from
3c8a9c5
to
7c039ad
Compare
|
I have moved the Audible Sound cue reset commit to #11482 |
| } | ||
| } | ||
| return getEndSecond(pDeck); | ||
| return samplePositionToSeconds(endSamplePosition, pDeck); |
There was a problem hiding this comment.
This and L1138: why not use existing return getEndSecond(pDeck);?
That way the fix is only the renaming and the extra check in the if (lastSound > 0) branch.
There was a problem hiding this comment.
I wanted to avoid the overhead to fetch endSamplePosition again in getEndSecond(). It is also one less redirection for a better understanding.
| qWarning() << "Audible Sound Cue ends after track end using:" | ||
| << pTrack->getLocation(); |
There was a problem hiding this comment.
maybe add
<< "Returning last sample instead.";?
| @@ -1119,11 +1119,17 @@ double AutoDJProcessor::getFirstSoundSecond(DeckAttributes* pDeck) { | |||
| return 0.0; | |||
| } | |||
|
|
|||
| double endSamplePosition = pDeck->trackSamples(); | |||
There was a problem hiding this comment.
move this down to where it's needed?
or even use it directly for the <= comparison?
| @@ -1074,16 +1074,18 @@ void AutoDJProcessor::playerOutroEndChanged(DeckAttributes* pAttributes, double | |||
| } | |||
|
|
|||
| double AutoDJProcessor::getIntroStartSecond(DeckAttributes* pDeck) { | |||
| double endSamplePosition = pDeck->trackSamples(); | |||
There was a problem hiding this comment.
here and below:
trackEndSample for consistent naming?
|
Whoops, too late... |
Sorry, I'll wait a little more next time. |
This likely fixes #11448
All positions that are used in Auto DJ are now clamped to the track end.
This ensures that the Auto DJ keeps going even if a faulty track is played.
This also refreshes the invisible AudibleSound cue when the user re-analyzes waveforms.Before, the only way to reset this cue was to reset either intro or outro, which they might want to keep.