-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fidlib Unit-Tests #11502
Fidlib Unit-Tests #11502
Conversation
GCC 13.0.1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed. Test is failing as expected.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM otherwise.
src/test/enginefilterbiquadtest.cpp
Outdated
double resp0, phase0; | ||
resp0 = fid_response_pha(filt, 1000 / 44100, &phase0); | ||
EXPECT_DOUBLE_EQ(resp0, 1); | ||
EXPECT_DOUBLE_EQ(phase0, 0); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
phase0 could be uninitialized on failure and might be 0 implicitly. Can we initialize to some placeholder value? same applies to analysisLpBe4
.
Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, though I can't judge how robust these tests are actually are.
This adds two tests, that aims to detect bugs like #11483
This is one step closer to the source, compared to #11489 and can be a low impact alternative. We may consider to close the outer test PR or keep/tweak it to be an extension to this one.