glwaveformrenderbackground

[m0dB]

glwaveformrenderbackground is a replacement for waveformrenderbackground, which uses glClear to clear the waveform widget. this is a potential fix for #11164

[Swiftb0y]

Thank you. I can confirm that this fixes #11164.

[Swiftb0y]

@uklotzde can you spare a couple minutes to confirm this fixes #11164 for you as well?

[uklotzde]

https://imgflip.com/i/7k4cx5

Maintaining 3 differing major branches is a PITA for everyone involved and waste of scarce resources. The project should be aware of the consequences of its decisions. Last time that I build 2.3.

[uklotzde]

@Swiftb0y Works for me.

[Swiftb0y]

Thank you. 2.3 will be retired soon. 2.3.5 will likely be our last 2.3 release before 2.4

[daschuer]

I can confirm that the waveforms are still working @60 Hz on Ubuntu Focal and
openGL 4.3 (Mesa Intel(R) UHD Graphics (CML GT2))
Thank you for the fats fix.

[m0dB]

I have made a minor change based on @Swiftb0y review (aesthetic only, code execution should be identical).

[Swiftb0y]

LGTM. I highly thank you for helping us fix the issue. I highly doubt anyone else would've identified and contributed a potential fix as fast as you did in this PR.

[uklotzde]

@m0dB You contributions are greatly appreciated and needed to keep Mixxx alive.

[m0dB]

Thanks guys :-)

It sure helped that I have been deep down the waveform renderer rabbit hole!