Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AnalyzerWaveform: Fix commented out code #11561

Merged
merged 1 commit into from
May 16, 2023
Merged

AnalyzerWaveform: Fix commented out code #11561

merged 1 commit into from
May 16, 2023

Conversation

uklotzde
Copy link
Contributor

The commented out code didn't compile.

TODO: The code does not contain any references how the frequency bands have been chosen nor why selected filters are used.

Swiftb0y
Swiftb0y approved these changes May 16, 2023
View reviewed changes
Copy link
Member

@Swiftb0y Swiftb0y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I'd appreciate if you'd use the naming scheme for the sake of consistency.

src/analyzer/analyzerwaveform.cpp Outdated Show resolved Hide resolved
@Swiftb0y
Copy link
Member

Build failures are unrelated, but clang-format is complaining.

Swiftb0y
Swiftb0y approved these changes May 16, 2023
View reviewed changes
Copy link
Member

@Swiftb0y Swiftb0y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. I'd still like to wait with merging until CI passes. Unfortunately that seems to be broken right now because azure...

daschuer
daschuer approved these changes May 16, 2023
View reviewed changes
Copy link
Member

@daschuer daschuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All green now. LGTM. Thank you.

@daschuer daschuer merged commit 393ddc4 into mixxxdj:main May 16, 2023
@uklotzde uklotzde deleted the analyzerwaveform branch May 16, 2023 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daschuer daschuer daschuer approved these changes

@Swiftb0y Swiftb0y Swiftb0y approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@uklotzde @Swiftb0y @daschuer