Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Numark DJ2GO2 Touch: add missing loop_out mapping for the right deck #11595

Merged
merged 1 commit into from
May 29, 2023

Conversation

r0d0dendr0n
Copy link

Added a missing section for the DJ2GO2Touch.rightDeck.loopOut.input key to the Numark DJ2GO2 Touch controller scheme.

I found that changing the source branch of a PR is not possible so I've created a new one. Please remove the old PR 11594 if not needed.

…ey to the Numark DJ2GO2 Touch controller scheme.
@JoergAtGithub
Copy link
Member

LGTM! Thank you!

@JoergAtGithub JoergAtGithub merged commit 7e2fc96 into mixxxdj:2.3 May 29, 2023
@ronso0
Copy link
Member

ronso0 commented May 29, 2023

I found that changing the source branch of a PR is not possible so I've created a new one.

In the PR page we can change the base branch, and locally you can git rebase -i [repo/branch]. In the editor window you could simply¹ remove all parent commits so only your commits are left. Then force-push.

¹in case of rebasing a main branch onto 2.3 there are hundreds or thousands commits. #11594 was just one commit so you could have noted the commit hash, delete the branch, create a new one with the same name, cherry-pick that commit, force-push.

@r0d0dendr0n
Copy link
Author

I found that changing the source branch of a PR is not possible so I've created a new one.

In the PR page we can change the base branch, and locally you can git rebase -i [repo/branch]. In the editor window you could simply¹ remove all parent commits so only your commits are left. Then force-push.

¹in case of rebasing a main branch onto 2.3 there are hundreds or thousands commits. #11594 was just one commit so you could have noted the commit hash, delete the branch, create a new one with the same name, cherry-pick that commit, force-push.

Your git skills are clearly far superior to mine. I admire that.
TBH I tried to hack something out, because I like clean solutions and order as well. It took me 2h to yield with a thought that searching for a solution that people, who seem to know more than me, describe as impossible is not worth it. The effort spent on form outweights the effort spent on content massively. I guess I have much to learn about git.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Numark DJ2GO2 Touch missing part of mapping for pad 2 in manual loop mode for the right deck
3 participants