Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export CSV: fixing null values in export #11668

Merged
merged 1 commit into from
Jun 21, 2023
Merged

Export CSV: fixing null values in export #11668

merged 1 commit into from
Jun 21, 2023

Conversation

burnsak
Copy link
Contributor

@burnsak burnsak commented Jun 19, 2023 •
edited
Loading

Improper location of right-alignment role caused fallthrough of export fields into the TextAlignment role instead of the DisplayRole leading null values in export.

Fixes: #11657

Seems to be an unintended consequence of edits from #11634

@ronso0
Copy link
Member

ronso0 commented Jun 19, 2023

Whoopsy...
Thanks for the quick fix. I'll take a look asap.

@daschuer
Copy link
Member

Thank you for this contribution.
Before merge, we need your permission to distribute your changes.
Please sign: https://docs.google.com/a/mixxx.org/spreadsheet/viewform?formkey=dEpYN2NkVEFnWWQzbkFfM0ZYYUZ5X2c6MQ
and comment here when done.

@burnsak
Copy link
Contributor Author

burnsak commented Jun 20, 2023

I've signed the permission doc.

ronso0
ronso0 requested changes Jun 20, 2023
View reviewed changes
src/library/basetracktablemodel.cpp Outdated Show resolved Hide resolved
src/library/basetracktablemodel.cpp Outdated Show resolved Hide resolved
@ronso0 ronso0 added this to the 2.4.0 milestone Jun 20, 2023
@burnsak
Export CSV: fixing null values in export due to improper location of …
94a896b 
…right-alignment role

fixed spelling in comment and added breaks to switch statements

Update src/library/basetracktablemodel.cpp

Rewording of comment improves clarity of M_FALLTHROUGH_INTENDED behaviour

Co-authored-by: ronso0 <ronso0@mixxx.org>

reverting unecessary breaks
@ronso0
Copy link
Member

ronso0 commented Jun 21, 2023

Thanks for this fix, LGTM!

@ronso0 ronso0 merged commit b437a9f into mixxxdj:2.4 Jun 21, 2023
@burnsak
Copy link
Contributor Author

burnsak commented Jun 21, 2023

Thanks for the feedback and help with this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uklotzde uklotzde uklotzde left review comments

@ronso0 ronso0 ronso0 requested changes

@Swiftb0y Swiftb0y Swiftb0y left review comments

Assignees
No one assigned
Labels
library regression
Projects
None yet
Milestone
2.4.0
Development

Successfully merging this pull request may close these issues.
5 participants
@burnsak @ronso0 @daschuer @uklotzde @Swiftb0y