fix OpenGL version detection #11673
Merged
fix OpenGL version detection #11673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Finally with Wayland high DPI scaling Just Works automatically without needing to set the environment variable |
Be-ing
commented
Jun 22, 2023
|
On my Windows11 laptop I get: |
Swiftb0y
reviewed
Jun 22, 2023
This allows OpenGL waveforms to be used with the Wayland Qt Platform Abstraction on KDE and Weston. Though GL_MAJOR_VERSION and GL_MINOR_VERSION reported much higher versions (4.6 when tested on Intel UHD Graphics 770 (ADL-S GT1)), QSurfaceFormat reports 2.0 on KDE Wayland and Weston (somehow it reports 2.1 on GNOME Wayland though) and 2.1 with the Xcb QPA. QSurfaceFormat does not report higher versions if they are requested in the OpenGLWindow constructor.
Swiftb0y
approved these changes
Jun 22, 2023
There was a problem hiding this comment.
LGTM. can confirm this to also fix the issue on Fedora 38 (Gnome running XWayland). There are other issues on Wayland though I'll file in separate gh issues.
This probably doesn't make any difference on MacOS, but lets wait with merging until someone confirms it.
|
I'll test on macOS this weekend. |
|
It works fine on macOS, so I think this can be merged without issue. |
|
LGTM! Thank you! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows OpenGL waveforms to be used with the Wayland Qt Platform Abstraction on KDE and Weston. Though GL_MAJOR_VERSION and GL_MINOR_VERSION reported much higher versions (4.6 when tested on Intel UHD Graphics 770 (ADL-S GT1)), QSurfaceFormat reports 2.0 on KDE Wayland and Weston (somehow it reports 2.1 on GNOME Wayland though) and 2.1 with the Xcb QPA. QSurfaceFormat does not report higher versions if they are requested in the OpenGLWindow constructor.
This has only been tested on Linux. @m0dB can you test on macOS? @JoergAtGithub could you test on Windows?