Fixed unnecessary transfer of the ownership before release which returns the pointer itself #11726
Conversation
…rns the pointer itself
| // pTag we need to release the ownership to avoid double deletion! | ||
| pFrame.release(); | ||
|
|
||
| // Release returns a pointer to the managed object and releases the ownership, |
There was a problem hiding this comment.
The comment is obsolete after dropping the 2-step get-release pattern. Repeating the std definition of release() is pointless and confusing. Also applies to other locations in the code.
The 2-step pattern is required for exception safe C++ programming. But since any exception thrown by addFrame() is expected to be fatal a resource leak doesn't matter then.
There was a problem hiding this comment.
This code has been written with purpose and the comment explained why. If you decide to take a simpler approach then delete the obsolete comment. I don't care, does not really matter. But please change it in a consistent way.
There was a problem hiding this comment.
The resource leak reported by Coverity is obviously a false positive.
| // Release returns a pointer to the managed object and releases the ownership, | ||
| // the plain pointer in pFrame is owned and managed by pTag |
There was a problem hiding this comment.
Something like this should be sufficient
| // Release returns a pointer to the managed object and releases the ownership, | |
| // the plain pointer in pFrame is owned and managed by pTag | |
| // pTag takes the ownership of pFrame |
These were reported as resoource leak by Coverity Scan, not real issues, but also an unnecessary commands. So this is the cleanest way to silence the warning.
While going through these warnings I noticed also #11725 which looks similar, but is a real ressource leak.