WTrackProperty: show simple editor on delayed double-click #11755

ronso0 · 2023-07-22T12:05:08Z

show a simple QLineEdit after selected-click (delayed double click) onto track property labels

a coffee break project to help with my tag editing workflow (quick in-deck tag editing), i.e. create a fast alternative to double-click -> Track Properties -> click desired property line edit -> edit -> hit Apply:

Gonna share this early, but Draft until it's polished.

styles for line edit
~~get real double-click interval, use x3 for selected click~~ 2s timeout are fine
use timer, reset 'selected' state automatically
visual feedback for 'selected' state (while widget expects second click):
new selected widget property, WTrackProperty[selected="true"] { background: red; };
add selected-click info to tooltips

May reuse #11752 for comments, but QLineEdit is fine for now.

ronso0 · 2023-07-25T21:50:45Z

I'll probably keep polishing this, but it has already proven useful & usable in real life.

ronso0 · 2023-07-26T20:52:14Z

This is very inviting, I edit and tag my tracks much more often now, and more spontaneously than before, when editing was rather clunky with Track Info or with the library.
(#11764 definitely helps, but this is way easier. )

ronso0 · 2023-08-16T12:34:52Z

Ready to roll!

There's a new tr string for the respective tooltip.

ronso0 · 2023-09-20T10:13:37Z

I added a workaround a Qt bug that became obvious with the new hover styles:
hover gets stuck when the track menu is opened which is kind of irritating. The hover state can only be reset by hovering the widget again after closing the menu.

Workaround is to post a QLeaveEvent when the menu is shown.

Need to test whether this is still required with Qt6.

ronso0 · 2023-10-15T23:07:08Z

rebased onto main

ronso0 · 2023-10-20T08:27:35Z

I added a workaround a Qt bug that became obvious with the new hover styles: hover gets stuck when the track menu is opened which is kind of irritating. The hover state can only be reset by hovering the widget again after closing the menu.

Workaround is to post a QLeaveEvent when the menu is shown.

Need to test whether this is still required with Qt6.

Yes, it is.

I also improved some comments. Ready for review.

ronso0 · 2023-12-25T19:27:40Z

~~this is now based on #12004~~
rebased onto main

ronso0 · 2024-03-29T13:40:36Z

This works great, except: clicking outside the editor ('blank' area) doesn't close it.
Related: #12966 (comment))

ronso0 · 2024-03-31T15:05:14Z

Very strange: after rebasing (main with new drag'n'drop threshold) hovering a WTrackProperty initiates a drag. THOUGH this is not caused by c++ changes but by qss selector WTrackProperty:hover.
🤷

daschuer

Works good. I have only two minor comments

daschuer · 2024-04-01T21:11:45Z

src/widget/wtrackproperty.cpp

+namespace {
+// Duration (ms) the widget is 'selected' after left click, i.e. the duration
+// a second click would open the value editor
+constexpr int selectedClickTimeout = 2000;


Suggested change

constexpr int selectedClickTimeout = 2000;

constexpr int kSelectedClickTimeoutMs = 2000;

daschuer · 2024-04-01T21:15:25Z

src/widget/wtrackproperty.cpp

+
+    if (!m_pSelectedClickTimer) {
+        // create & start the timer
+        m_pSelectedClickTimer = new QTimer(this);


This can also become a parented pointer.

daschuer

LGTM, Thank you.

* load a track * click a track label -> is now 'selected' (qProperty for qss) * click again within 2 sec * editor is created * edit text * to cancel: press Esc to cancel * to apply & close: press Return or focus another widget

* hover effect * 'selected' state (waiting for second click to start editing) * editor Note: Shade has no hover effects (at all)

ronso0 · 2024-04-02T23:47:22Z

I squashed the fixup.

daschuer · 2024-04-03T09:43:43Z

Thank you.

ronso0 · 2024-04-03T09:56:52Z

Wooohoo 🎉
Thanks for reviewing @daschuer

ronso0 · 2024-04-16T08:14:18Z

Review after having used this for a few months:
quite often I expected the editor to open after the first click (select), probably due to the hover effect.
I'll check if I can make it act on first click and while leaving drag'n'drop as is.

And I expect the cursor at the front of the selection to match watch the label displayed (even if that is different to how line edits usually behave).

github-actions bot added the ui label Jul 22, 2023

ronso0 linked an issue Jul 22, 2023 that may be closed by this pull request

enable editable track metadata in decks with 'selected click' lineedits #9981

Closed

ronso0 force-pushed the track-label-editor branch from ba395ea to c1361cd Compare July 25, 2023 20:52

github-actions bot added the skins label Jul 25, 2023

ronso0 force-pushed the track-label-editor branch from c1361cd to d718ca3 Compare July 25, 2023 21:07

ronso0 mentioned this pull request Jul 26, 2023

Refocus library #11767

Merged

ronso0 added the feature label Jul 28, 2023

ronso0 force-pushed the track-label-editor branch from d718ca3 to 20847ed Compare July 28, 2023 13:29

ronso0 marked this pull request as ready for review August 16, 2023 12:34

ronso0 force-pushed the track-label-editor branch from 20847ed to 92a3694 Compare August 16, 2023 12:35

ronso0 force-pushed the track-label-editor branch from 92a3694 to 8ec4312 Compare September 20, 2023 10:10

ronso0 force-pushed the track-label-editor branch from 8ec4312 to 36c822e Compare September 20, 2023 10:15

ronso0 mentioned this pull request Oct 12, 2023

feature request: Set BPM counter to specific value #12086

Open

ronso0 changed the base branch from 2.4 to main October 15, 2023 23:06

ronso0 force-pushed the track-label-editor branch 2 times, most recently from 6f82aad to 2239f22 Compare October 20, 2023 08:27

ronso0 mentioned this pull request Oct 22, 2023

Reset tapped BPM button #12209

Closed

ronso0 force-pushed the track-label-editor branch from 2239f22 to af102fc Compare December 25, 2023 19:26

github-actions bot added the build label Dec 25, 2023

ronso0 force-pushed the track-label-editor branch 2 times, most recently from 57a9196 to 8351e4f Compare January 3, 2024 01:33

ronso0 force-pushed the track-label-editor branch 2 times, most recently from e3732be to 71a7625 Compare February 12, 2024 00:06

ronso0 force-pushed the track-label-editor branch from 71a7625 to 393c128 Compare February 12, 2024 00:10

ronso0 force-pushed the track-label-editor branch from 393c128 to 4cc338d Compare March 29, 2024 21:38

daschuer requested changes Apr 1, 2024

View reviewed changes

daschuer approved these changes Apr 2, 2024

View reviewed changes

ronso0 added 4 commits April 3, 2024 01:14

WTrackProperty: add 'selected click' in-place editor

d763716

* load a track * click a track label -> is now 'selected' (qProperty for qss) * click again within 2 sec * editor is created * edit text * to cancel: press Esc to cancel * to apply & close: press Return or focus another widget

skins: add styles for WTrackPropertyEditor

7ece885

* hover effect * 'selected' state (waiting for second click to start editing) * editor Note: Shade has no hover effects (at all)

add tooltip for WTrackProperty's select'n'click inline editor

57eae25

WTrackProperty: unset hover state when menu is opened

687ed2f

ronso0 force-pushed the track-label-editor branch from 396b4c5 to 687ed2f Compare April 2, 2024 23:14

daschuer merged commit 210c739 into mixxxdj:main Apr 3, 2024
13 checks passed

ronso0 deleted the track-label-editor branch April 3, 2024 09:56

ronso0 mentioned this pull request Apr 4, 2024

(fix) Drag'n'drop: avoid unintended drag on hover (WTrackProperty, WCoverArt etc.) #13035

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

WTrackProperty: show simple editor on delayed double-click #11755

WTrackProperty: show simple editor on delayed double-click #11755

ronso0 commented Jul 22, 2023 •

edited

Loading

ronso0 commented Jul 25, 2023

ronso0 commented Jul 26, 2023 •

edited

Loading

ronso0 commented Aug 16, 2023

ronso0 commented Sep 20, 2023 •

edited

Loading

ronso0 commented Oct 15, 2023

ronso0 commented Oct 20, 2023

ronso0 commented Dec 25, 2023 •

edited

Loading

ronso0 commented Mar 29, 2024

ronso0 commented Mar 31, 2024

daschuer left a comment

daschuer Apr 1, 2024

daschuer Apr 1, 2024

daschuer left a comment

ronso0 commented Apr 2, 2024

daschuer commented Apr 3, 2024

ronso0 commented Apr 3, 2024

ronso0 commented Apr 16, 2024 •

edited

Loading

	constexpr int selectedClickTimeout = 2000;
	constexpr int kSelectedClickTimeoutMs = 2000;

WTrackProperty: show simple editor on delayed double-click #11755

WTrackProperty: show simple editor on delayed double-click #11755

Conversation

ronso0 commented Jul 22, 2023 • edited Loading

ronso0 commented Jul 25, 2023

ronso0 commented Jul 26, 2023 • edited Loading

ronso0 commented Aug 16, 2023

ronso0 commented Sep 20, 2023 • edited Loading

ronso0 commented Oct 15, 2023

ronso0 commented Oct 20, 2023

ronso0 commented Dec 25, 2023 • edited Loading

ronso0 commented Mar 29, 2024

ronso0 commented Mar 31, 2024

daschuer left a comment

Choose a reason for hiding this comment

daschuer Apr 1, 2024

Choose a reason for hiding this comment

daschuer Apr 1, 2024

Choose a reason for hiding this comment

daschuer left a comment

Choose a reason for hiding this comment

ronso0 commented Apr 2, 2024

daschuer commented Apr 3, 2024

ronso0 commented Apr 3, 2024

ronso0 commented Apr 16, 2024 • edited Loading

ronso0 commented Jul 22, 2023 •

edited

Loading

ronso0 commented Jul 26, 2023 •

edited

Loading

ronso0 commented Sep 20, 2023 •

edited

Loading

ronso0 commented Dec 25, 2023 •

edited

Loading

ronso0 commented Apr 16, 2024 •

edited

Loading