Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle setting loop_in and loop_out at the same position #11771

Merged
merged 3 commits into from
Aug 2, 2023
Merged

Handle setting loop_in and loop_out at the same position #11771

merged 3 commits into from
Aug 2, 2023

Conversation

ronso0
Copy link
Member

@ronso0 ronso0 commented Jul 28, 2023

  • loop_in @ loop_out clears loop, sets loop_in
  • loop_out @ loop_in is ignored

I also added two tests.

Closes #10600

@ronso0 ronso0 linked an issue Jul 28, 2023 that may be closed by this pull request
loop_in & loop_out at same postion should not create a loop #10600
Closed
Swiftb0y
Swiftb0y approved these changes Aug 2, 2023
View reviewed changes
Copy link
Member

@Swiftb0y Swiftb0y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find it a little weird that the behavior is not "symmetrical" but if that's easiest to implement then lets go for it.

daschuer
daschuer approved these changes Aug 2, 2023
View reviewed changes
Copy link
Member

@daschuer daschuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have just tested it and it works good. IMHO the different behavior is desired because we do not allow to set a loop-out before the loop-in. Hitting exactly loop-in is not special in that regards.

@daschuer daschuer merged commit 473d1ca into mixxxdj:2.3 Aug 2, 2023
8 checks passed
@daschuer daschuer added this to the 2.3.6 milestone Aug 3, 2023
@ronso0 ronso0 deleted the loop-in-out-in-same-place branch August 5, 2023 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daschuer daschuer daschuer approved these changes

@Swiftb0y Swiftb0y Swiftb0y approved these changes

Assignees
No one assigned
Labels
code quality
Projects
None yet
Milestone
2.3.6
Development

Successfully merging this pull request may close these issues.

loop_in & loop_out at same postion should not create a loop
3 participants
@ronso0 @daschuer @Swiftb0y