Disable GL VU-Meters on windows by default. #11787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…terGL to override the default.
Swiftb0y
reviewed
Aug 3, 2023
Comment on lines
+115
to
+117
| } else if (QString::fromLocal8Bit(argv[i]).contains( | ||
| "--enableVuMeterGL", Qt::CaseInsensitive)) { | ||
| m_useVuMeterGL = true; |
There was a problem hiding this comment.
these are hidden from -h and so forth, is that intentional?
Swiftb0y
reviewed
Aug 3, 2023
ywwg
approved these changes
Aug 4, 2023
|
This fixes #11789 |
Co-authored-by: Swiftb0y <12380386+Swiftb0y@users.noreply.github.com>
|
Done. |
Swiftb0y
approved these changes
Aug 4, 2023
|
In 2.4 we have decided to make "false" default for all. I have merged 2.3 into 2.4 and reverted this PR during resolving of conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes: #11785
And adds the command line option --enableVuMeterGL to override the new default.