Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to libdjinterop 0.19.2 #11816

Merged
merged 1 commit into from
Aug 12, 2023
Merged

Conversation

mr-smidge
Copy link
Contributor

@mr-smidge mr-smidge commented Aug 12, 2023

Update to libdjinterop 0.19.2, providing two fixes:

  • Fix for a bug whereby the exported main cue point would be disregarded by hardware players.
  • Fix high-res waveform not appearing on some tracks.

@github-actions github-actions bot added the build label Aug 12, 2023
@mr-smidge
Copy link
Contributor Author

mr-smidge commented Aug 12, 2023

@daschuer if you are happy with this PR, the new Ubuntu packages will need to be copied to the Mixxx PPA as usual: https://launchpad.net/~xsco/+archive/ubuntu/djinterop

@JoergAtGithub
Copy link
Member

VCPKG update port is here: microsoft/vcpkg#33125

@JoergAtGithub JoergAtGithub added this to the 2.4.0 milestone Aug 12, 2023
@daschuer
Copy link
Member

@JoergAtGithub can you provide a cherry-pick PR of microsoft/vcpkg#33125 against the 2.4 branch of https://github.com/mixxxdj/vcpkg
We have stopped merging from Microsoft upstream during 2.4-beta.
I will merge from Microsoft upstream to 2.5 once microsoft/vcpkg#33125 is merged.

Copy link
Member

@daschuer daschuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thank you.

@daschuer daschuer merged commit ed76470 into mixxxdj:2.4 Aug 12, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants