BaseExternalLibraryFeature: Add ability to import external playlists as crates #11852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Swiftb0y
reviewed
Aug 21, 2023
| } else { | ||
| QMessageBox::warning(nullptr, | ||
| tr("Crate Creation Failed"), | ||
| tr("Could not create crate, it most likely already exists: ") + playlist); |
There was a problem hiding this comment.
would be nice to have a better error message here but I guess thats not currently possible with the insertCrate API, right?
There was a problem hiding this comment.
Exactly, anything more specific would likely require refactoring those APIs (aside from manually checking the crates, though I haven't dug too far into the crate APIs yet).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small extension to the existing import-as-playlist action found in
BaseExternalLibraryFeaturethat enables users to import external playlists as crates too:Crates have the unique property that their names must be unique, so the import can fail if the name already exists. Currently this is dealt with by presenting an error dialog, but we may consider prompting the user e.g. to specify a custom name instead or to merge the tracks into the existing crate. Ideas welcome.
Something else to consider is that the import is currently synchronous and can be quite slow for large external playlists (thousands of songs). This applies to the existing playlist import too though, therefore I would consider any optimizations to be out-of-scope for this PR.