Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logging: Include timestamps in messages by default #11861

Merged
merged 1 commit into from
Aug 28, 2023
Merged

Logging: Include timestamps in messages by default #11861

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/util/logging.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
#include <stdio.h>

#include <QByteArray>
#include <QDateTime>
#include <QFile>
#include <QFileInfo>
#include <QIODevice>
Expand Down Expand Up @@ -121,6 +122,8 @@ inline QString formatLogFileMessage(
QtMsgType type,
const QString& message,
const QString& threadName) {
QString timestamp = QDateTime::currentDateTime().toString("hh:mm:ss.zzz");

QString levelName;
switch (type) {
case QtDebugMsg:
Expand All @@ -140,7 +143,7 @@ inline QString formatLogFileMessage(
break;
}

return levelName + QStringLiteral(" [") + threadName + QStringLiteral("] ") + message;
return QStringLiteral("%1 %2 [%3] %4").arg(timestamp, levelName, threadName, message);
}

/// Actually write a log message to a file.
Expand Down
Loading