Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DlgAbout: Add Qt version to the dialog #11862

Merged
merged 4 commits into from
Aug 25, 2023
Merged

Conversation

fwcd
Copy link
Member

@fwcd fwcd commented Aug 24, 2023

A small QoL improvement that adds the Qt version to the about dialog:

Screenshot 2023-08-25 at 00 38 17

@github-actions github-actions bot added the ui label Aug 24, 2023
@@ -78,8 +78,27 @@
</item>
<item>
<layout class="QGridLayout" name="gridLayout">
<item row="2" column="1">
<widget class="QLabel" name="platform_label">
<item row="0" column="0">
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I apologize for the slightly noisy diff: The markup was quite hard to read since rows/columns were in no recognizable order, therefore I've sorted them first. Reviewing commit-by-commit might be the easiest here.

Copy link
Member

@ronso0 ronso0 Aug 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
good ol' QtCreator used to randomize item order when items were added/moved in the GUI editor and diffs were unreviewable, especially for large preferences pages.
Though, out if laziness I tried it lately and this seems to be fixed.

Copy link
Member

@Swiftb0y Swiftb0y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Otherwise.

src/util/versionstore.cpp Outdated Show resolved Hide resolved
Co-authored-by: Swiftb0y <12380386+Swiftb0y@users.noreply.github.com>
Copy link
Member

@Swiftb0y Swiftb0y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, waiting for CI

Copy link
Member

@Holzhaus Holzhaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@Holzhaus Holzhaus merged commit 1ba54fc into mixxxdj:main Aug 25, 2023
11 checks passed
@fwcd fwcd deleted the about-qt-version branch August 25, 2023 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants