-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DlgAbout: Add Qt version to the dialog #11862
Conversation
@@ -78,8 +78,27 @@ | |||
</item> | |||
<item> | |||
<layout class="QGridLayout" name="gridLayout"> | |||
<item row="2" column="1"> | |||
<widget class="QLabel" name="platform_label"> | |||
<item row="0" column="0"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I apologize for the slightly noisy diff: The markup was quite hard to read since rows/columns were in no recognizable order, therefore I've sorted them first. Reviewing commit-by-commit might be the easiest here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
good ol' QtCreator used to randomize item order when items were added/moved in the GUI editor and diffs were unreviewable, especially for large preferences pages.
Though, out if laziness I tried it lately and this seems to be fixed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM Otherwise.
Co-authored-by: Swiftb0y <12380386+Swiftb0y@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, waiting for CI
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
A small QoL improvement that adds the Qt version to the about dialog: